1604866 - See watchpoints in the breakpoints pane

Status: NEW

(DevTools :: Debugger, enhancement, P3)

Description

[Jason Laster [:jlast]]

Currently, watchpoints are managed in the scopes pane and associated with the object property they are defined on.

It would be nice if we also showed watchpoints in the breakpoints pane and let users remove them while the program is running.

Comment 1

[janelledement]

@jlast, would it maybe make sense to make a new pane for watchpoints exclusively (like xhr and DOM mutation breakpoints)? Or would they display in the regular breakpoints area? Interested in this idea because I was thinking the same thing too. Once you set a watchpoint, there should be an easier way to see and manage it outside of the scopes area especially if the watchpoint is deeply nested and inconvenient to get to in scopes.

Comment 2

[Jason Laster [:jlast]]

hmm, i'd be open to a new pane..

Comment 3

[:Harald Kirschner :digitarald]

I am slightly concerned about growth of breakpoint panes, but I agree that we need to expose this amazingly useful feature better.

Would the panel have a way of adding a watchpoint?

Comment 4

[janelledement]

I was imagining that the panel wouldn't be for setting the watchpoints exactly but for managing them, like to disable (checkbox) or delete (x out) them the way the other breakpoints are managed in their own panes.

Comment 5

[David Walsh :davidwalsh]

I agree with Janelle that the panel doesn't need to allow setting, at least not at first. The DOM Mutation Breakpoint pane has a helpful message that sends the user to the inspector, because it's easy to visualize and understand, but I get the feeling Watchpoints may not be that simple? That said, I haven't used them extensively.

Comment 6

[janelledement]

I guess it could be comparable to the DOM mutation breakpoints message. The watchpoint pane message would direct the user to the scopes pane to set new watchpoints instead in this case.

Comment 7

[janelledement]

Attachment: jQuery_•_TodoMVC_and_mozilla-central_—_plugin-container_◂_mach_run_—_80×24.png

This is what I had in mind for the empty watchpoints message, just like the DOM mutation breakpoint pane empty message.

Comment 8

[janelledement]

Attachment: Adds watchpoints pane.

WIP Adds a watchpoint pane to make watchpoints more visible for the user and more manageable.
Notes: THe watchpoints pane is only visible when the debugger is paused. Add a watchpoint and notice how it is displayed in the pane. You can also delete watchpoints by using the x-out button in the pane.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:bomsy, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 10

[Hubert Boma Manilla (:bomsy)]

This is not a high priority atm, and the team is reduced. Maybe we will have a look in the future.

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.