1604873 - Feed subscribe dialog: url field doesn't enable the Verify button

Status: RESOLVED FIXED

(MailNews Core :: Feed Reader, defect, P2)

Description

[alta88]

1. Drag and drop move of a feed into a different folder, and ctrl dnd copy to another account is broken.
2. Clicking the url field doesn't enable the Verify button.

Both work in 68.3 but no longer in beta 72. Likely a Bug 1534163 regression.

Comment 1

[Jorg K (CEST = GMT+2)]

Why is a regression P2?

Comment 2

[Magnus Melin [:mkmelin]]

Because it's something we should fix for the next ESR, but it's not major enough to block doing a 73 beta.

Comment 3

[Jorg K (CEST = GMT+2)]

Who said that an unfixed P1 automatically becomes a blocker? Sure, if you notice a regression one day before the release, you wouldn't block on it. Also see: https://firefox-bug-handling.mozilla.org/triage-bugzilla. IMHO, any visible regression should be a P1, whether to manage to fix it in the current cycle is another story. You really want to get this fixed in TB 78 when you'll have many other things to worry about? Or shouldn't it be fixed rather sooner than later, and if due to the holidays it doesn't happen in 72, it should happen in 73?

BTW, we're not blocking on these 17 P1 bugs either. You might want to review the priorities on them.

EDIT: Oops, forgot to paste the link: https://mzl.la/2PVqRPa

Comment 4

[Magnus Melin [:mkmelin]]

Khushil, please have a look. More dnd.

Comment 5

[Khushil Mistry [:khushil324]]

(In reply to alta88 from comment #0)

1. Drag and drop move of a feed into a different folder, and ctrl dnd copy to another account is broken.
2. Clicking the url field doesn't enable the Verify button.

Both work in 68.3 but no longer in beta 72. Likely a Bug 1534163 regression.

I am not able to reproduce the dnd issues. I can reproduce the URL issue. I am currently on Trunk i.e. 75.0a1 with Mac.

Comment 6

[Khushil Mistry [:khushil324]]

Attachment: Bug-1604873_enable-verify-button-feed-subscribe-0.patch

Comment 7

[Magnus Melin [:mkmelin]]

Hmm, would really be better with one bug per issue.

Ah, so the button issue would be from bug 1584462 I guess. <input> doesn't have a "focused" attribute.

I don't really see a problem with the dnd either. I did once get an error JavaScript error: resource:///modules/FeedUtils.jsm, line 1167: TypeError: destDS.push is not a function.

https://searchfox.org/comm-central/rev/796d62b956c9e00ad8725488f7e6cfad734e9308/mailnews/extensions/newsblog/content/FeedUtils.jsm#1167 should be destDS.data.push(sub);

Comment 8

[Magnus Melin [:mkmelin]]

Comment on attachment 9128062 [details] [diff] [review]
Bug-1604873_enable-verify-button-feed-subscribe-0.patch

Review of attachment 9128062 [details] [diff] [review]:
-----------------------------------------------------------------

This fixes the regression, but, I think we should really let the verify button be active always when the feed url has a value (so the whole line you're touching can be removed). Otherwise it's impossible to verify when using keyboard only, for one thing.
There's really an awful lot of things that are confusing in this dialog. To name a few: title/url field order is backwards when you want to add a new feed, the place of the buttons (not in context), and the whole issue of how feeds are organized in folders or not :/

Comment 9

[Wayne Mery (:wsmwk)]

There's really an awful lot of things that are confusing in this dialog. To name a few: title/url field order is backwards when you want to add a new feed, the place of the buttons (not in context), and the whole issue of how feeds are organized in folders or not :/

Completely agree. Do we have bugs to cover all the issues? from https://mzl.la/2VaYRd2 I'm not sure we do.

Comment 10

[Khushil Mistry [:khushil324]]

Attachment: Bug-1604873_enable-verify-button-feed-subscribe-1.patch

Comment 11

[Khushil Mistry [:khushil324]]

Should I open a bug and ask Aleca's view for restructuring the dialog?

Comment 12

[Magnus Melin [:mkmelin]]

I'll take a look at the bugs we have on file, and maybe file some more.

Comment 13

[Magnus Melin [:mkmelin]]

Filed bug 1617268 for the second issue of this bug.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0eec44e45273
Fix clicking the url field doesn't enable the verify button in Feed subscribe dialog. r=mkmelin