1605008 - DoH Rollout Extension: Heuristics run on network change when user has `network.trr.mode` set manually during first run

Status: VERIFIED FIXED

(Firefox :: Security, defect, P1)

Description

[Maxx Crawford [:mcrawford :maxx :maxxcrawford]]

Ported from GitHub issue #213

Steps to reproduce:

• Run build in clean profile
• Add the following prefs (in this order):
  • network.trr.mode;2
  • doh-rollout.debug;true (Optional)
  • doh-rollout.enabled;true
• Reset/change network connection

Fix from Github PR #214

This solution was to make sure to set the DOH_SKIP_HEURISTICS_PREF to true during the if case of the trrModePrefHasUserValue function

See commit for more details.

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1605008 - Don't overwrite skip heuristics pref to ensure heuristics aren't run after network changes. r=maxxcrawford

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d5e19823259f
Don't overwrite skip heuristics pref to ensure heuristics aren't run after network changes. r=maxxcrawford

Comment 3

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/d5e19823259f

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Is this something we need to uplift to Beta for Fx73?

Comment 5

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 9117611 [details]
Bug 1605008 - Don't overwrite skip heuristics pref to ensure heuristics aren't run after network changes. r=maxxcrawford

Beta/Release Uplift Approval Request

• User impact if declined: DNS over HTTPS heuristics are run after network changes even if the client state does not match the criteria to run them.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment 0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This fix was already landed in the github version of the add-on and this patch ports that fix into m-c.
• String changes made/needed:

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9117611 [details]
Bug 1605008 - Don't overwrite skip heuristics pref to ensure heuristics aren't run after network changes. r=maxxcrawford

DoH fix, approved for 73.0b5.

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ed2ff1a440fd

Comment 8

[Daniel Cicas [:dcicas], Release QA]

Hello,

I can confirm that this issue is fixed in Fx 73.0b5 and Fx nightly 74.0a1 (buildID: 20200115165527) on mac OS 10.15 as far as I remember this issue was only on mac OS.