1605043 - Fullscreen videos cropped

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: Audio/Video, defect, P3)

Description

[Trass3r]

User Agent: Mozilla/5.0 (Android 9; Mobile; rv:68.0) Gecko/68.0 Firefox/68.0

Steps to reproduce:

On a Xiaomi Mi 9T with its wide display fullscreen videos like YouTube are always cropped in landscape mode (fit to width instead of fit to content). The bottom part is missing. The yt app displays them correctly.

Comment 1

[Trass3r]

Actually it would be nice if one could pinch to zoom between fit to content and fit to width (and maybe even further in).

Comment 2

[Andreas Pehrson [:pehrsons]]

Thanks for filing!

I tried this vertical video and this 4:3 video on Firefox for Android 68.3.0 and couldn't reproduce. They did fit to content.

Could you link the video you used and attach a screenshot of what it looks like in fullscreen on your device?

Do you have the same issue with Firefox Preview? It is our new Android browser that long-term will replace Firefox for Android.

Comment 3

[Trass3r]

Yes they are cropped too, like in the first video I can't see the table.
Happens with Preview too.

Comment 4

[Andreas Pehrson [:pehrsons]]

Do you have a link and a screenshot of the problem?

Comment 5

[Trass3r]

Attachment: landscape mode

https://m.youtube.com/watch?v=dOfucXtyEsU
The presenter's name is already missing.

Comment 6

[Trass3r]

It's fine in Portrait Mode.

Comment 7

[Dan Minor [:dminor]]

Thanks for the screenshot and link!

Comment 8

[Dan Minor [:dminor]]

:jya, does this belong here or in another component? Thanks!

Comment 9

[Alastor Wu [:alwu]]

I can't reproduce this issue on my Pixel3XL, I've tried on both Firefox and Firefox Preview. I wonder if it's related with Xiaomi Mi's wide display screen, maybe we have to adjust our video frame when rendering? but I don't have any cue about possible root cause. Maybe John could give us some idea?

Comment 10

[Jan Henning [:JanH]]

Did somebody check whether the same thing possibly happens in Chrome, too?

I've seen some more reports of this phenomenon and
a) it seems this started when Youtube switched to using their own custom video player UI instead of the built-in browser HTML5 video player and
b) people reported this happening in Chrome, too, indicating that this is possibly in in fact bug in Youtube's own code and not a browser bug.

Comment 11

[Jean-Yves Avenard [:jya]]

I can reproduce on the pixel 4.

I can also reproduce it with Google Chrome on that same device.

So not sure we're doing anything wrong here.

Selected product is okay I believe.

Comment 12

[Brent Lewis]

I can reproduce this on my pixel 4 XL. It does not happen on Chrome.

Comment 13

[Brent Lewis]

Also, I found quite a lot of other people having the same issue. https://www.google.com/search?q=firefox+youtube+fullscreen+cut+off

Comment 14

[Adrie]

I'm having same issue on android. Other browsers like Chrome and other apps play videos normally. I'm using a moto e XT2052-1 with a resolution of 1520 x 720 on Android 10.

Comment 15

[Alastor Wu [:alwu]]

We recently got a fix for fullscreen video cropping issue on Android in bug 1659761, could you try to use latest Nightly to see if the issue still exists?
Thank you.

Comment 16

[janne.granstrom]

I like this behavior but we need make it more like vlc does it, so users can also stretch (pinch to browser the modes) the video to the handheld native screen, even the video original aspect ratio gets stretched.

We cannot do this with addons, so it need to be hard coded to the browser itself.

Comment 17

[Adrie]

Issue is fixed now in nightly and regular app. Thanks.

Comment 18

[Alastor Wu [:alwu]]

Per comment17, this issue seems be fixed by bug 1659761, so I'm going to close this bug. If we have other fullscreen related issues which are not the same as this cropping one, please file another bug.
Thank you.

Comment 19

[[e-mail]]

The issue ist not fixed. Whether in nightly, nor in stable. On every widescreen device, for example my OnePlus 8Pro, YouTube Videos got cropped in fullscreen. In Landscape everything ist fine. With Chrome or the App also everything ist fine.

Comment 20

[Alastor Wu [:alwu]]

Hi, botond,
Per comment19, are you aware any possible change which could result in cropped video on widescreen mobile device?
Thank you.

Comment 21

[Botond Ballo [:botond]]

(In reply to Alastor Wu [:alwu] from comment #20)

Per comment19, are you aware any possible change which could result in cropped video on widescreen mobile device?

I can't think of any of the top of my head.

fr4gg3l, please feel free to file a new bug to track the issue you're seeing, so that we can get a regression range for it and so on.

Comment 22

[Rob Adams]

I also see this in firefox nightly on a pixel 4 XL. YouTube cannot be used in full screen because a large portion of the top and bottom is cropped. Note in the YouTube app you can zoom in and out to get the cropped or uncropped aspect ratio. In FireFox you just get the cropped version which actually crops quite a lot off. You usually lose any text on the bottom of a video for example.

Comment 23

[Botond Ballo [:botond]]

(In reply to Rob Adams from comment #22)

I also see this in firefox nightly on a pixel 4 XL. YouTube cannot be used in full screen because a large portion of the top and bottom is cropped. Note in the YouTube app you can zoom in and out to get the cropped or uncropped aspect ratio. In FireFox you just get the cropped version which actually crops quite a lot off. You usually lose any text on the bottom of a video for example.

Thanks for reporting, but as I said in comment 21, please file a new ticket. We need to gather additional information such as a new regression window and we don't want that discussion to be buried at the bottom of an already-closed bug.

(You're welcome to add a comment here linking to the new ticket.)

Comment 24

[gurnanimohit82]

I've got the same issue in Pixel 6 with the latest version of Firefox. Is there any fix?

Comment 25

[Botond Ballo [:botond]]

(In reply to gurnanimohit82 from comment #24)

I've got the same issue in Pixel 6 with the latest version of Firefox.

Please file at https://github.com/mozilla-mobile/fenix/issues/