Closed Bug 1605145 Opened 5 years ago Closed 5 years ago

Fix the 'line too long' E501 flake8 errors in python/lldbutils

Categories

(Developer Infrastructure :: Lint and Formatting, defect)

defect
Not set
normal

Tracking

(firefox73 fixed)

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: jwatt, Assigned: jwatt)

References

Details

Attachments

(1 file)

Bug 1605144 will fix most of the flake8 lint errors in python/lldbutils, but it is unclear how to fix the 'line too long' E501 errors (flake8 gives no help, neither do any docs that I can find). So this bug will be a follow-up once someone figures out exactly what sort of wrapping will shut up flake8.

Note, you can skip specific error codes in the root .flake8 file. You can also add a # noqa comment to any line to ignore issues on that line only.

(In reply to Andrew Halberstadt [:ahal] from comment #1)

Note, you can skip specific error codes in the root .flake8 file.

Oh, using per-file-ignores, interesting.

Some files also seem to use the following at the top:

# lint_ignore=E501

See https://searchfox.org/mozilla-central/search?q=%23+lint_ignore%3DE501&case=true

But I couldn't get that to work.

You can also add a # noqa comment to any line to ignore issues on that line only.

Yeah, I actually do that for the patch in bug 1605144, but I thought it would be a bit messy for the 'line too long' errors.

Assignee: nobody → jwatt
Status: NEW → ASSIGNED
Pushed by jwatt@jwatt.org: https://hg.mozilla.org/integration/autoland/rev/b39ace10dbc2 Fix the 'line too long' E501 flake8 errors in python/lldbutils. r=ahal
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: