1605162 - Pausing in Workers and Remote Frames should update context selector

Status: RESOLVED FIXED

(DevTools :: Debugger, task, P1)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

When JS execution pauses in a worker or remote iframe the Context Selector should be properly updated to show the current (paused) context.

Honza

Comment 1

[Chris Peterson [:cpeterson]]

Tracking dt-fission-m2-mvp bugs for Fission Nightly (M6)

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Providing some specific STRs so, it's easier to test

1. Open Content Toolbox on any we page e.g. http://janodvarko.cz/tests/debugger/workers/
2. Select the Network panel and use the search feature - it starts a worker
3. Find the resource://devtools/client/netmonitor/src/workers/search/search.js in the source tree
4. Create BP in within the searchIinResource function
5. Repeat search in the Network panel -> hit the BP
6. Checkout the selector - it should show the right worker

Note that the selector is not even showing the network panel search worker in the list.

The Threads panel works as expected. It selects the worker properly and marks it as paused.

Honza

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

This is working in the browser toolbox, the context is updated when we pause. (I think it's more because a thread is selected when we pause, and the context selector reacts to the thread change).

I started working on a test to ensure this works when we pause in a remote frame, but the debugger does not pause at all in a remote frame when fission is enabled. I can't use a worker to pause in either, because we don't show workers in the context selector in the content toolbox at the moment.

Jason, is there a bug filed to enable that (pause at breakpoints in remote frames when fission is enabled), which I can use to block this bug?

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1605162 - Test that context selector is updated when pausing in a remote frame. r=Honza.

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Comment 4 has a link to the patch in which I added the test

Comment 6

[Jason Laster [:jlast]]

Nicolas, this might be a good meta bug to use
https://bugzilla.mozilla.org/show_bug.cgi?id=1574350

Comment 7

[Chris Peterson [:cpeterson]]

Tracking dt-fission-m2-mvp bugs for Fission Nightly milestone (M6c)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8d5d383ed08
Test that context selector is updated when pausing in a remote frame. r=Honza.

Comment 9

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/a8d5d383ed08