Closed Bug 1605189 Opened 2 years ago Closed 2 years ago

update in-tree robustcheckout with latest version

Categories

(Firefox Build System :: General, task)

task
Not set
normal

Tracking

(firefox73 fixed)

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: sheehan, Assigned: sheehan)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The version currently in-tree is pretty old. Updating with the latest gives us compatibility with the latest versions, Python 3 compat, and some better metrics.

Also needed this is apparently blocking bug 1561956 now.

This commit vendors robustcheckout from commit 584993820a97df in
version-control-tools. Updates include the removal of some dead code,
compatibility with the latest Mercurial, and Python 3 compatibility.

Pushed by cosheehan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/94edb5d84887
update in-tree robustcheckout with latest version r=firefox-build-system-reviewers,chmanchester

(In reply to Noemi Erli[:noemi_erli] from comment #3)

Backed out changeset 94edb5d84887 (Bug 1605189) for breaking Docker images builds CLOSED TREE
Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=282114838&repo=autoland&lineNumber=188

This one has nothing to do with Docker image builds, and is almost certainly not related to my changes.

https://treeherder.mozilla.org/logviewer.html#?job_id=282115212&repo=autoland

The failure here has to do with a missing ip, ifconfig or ipconfig command. robustcheckout doesn't use any of these binaries - it's just a Mercurial extension. I doubt there's any relation.

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=282114867&repo=autoland&lineNumber=213

This is just a timeout connection to FF-CI taskcluster. robustcheckout has nothing to do with this.

Since robustcheckout likely isn't affecting any of these failures (or at least, if it is, I have absolutely no idea how at this time), I'm going to try and land once more. If it needs a backout I'll debug further on Monday.

Flags: needinfo?(sheehan)
Pushed by cosheehan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b5b9d0ead3c3
update in-tree robustcheckout with latest version r=firefox-build-system-reviewers,chmanchester
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.