1605189 - update in-tree robustcheckout with latest version

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Description

[Connor Sheehan [:sheehan]]

The version currently in-tree is pretty old. Updating with the latest gives us compatibility with the latest versions, Python 3 compat, and some better metrics.

Also needed this is apparently blocking bug 1561956 now.

Comment 1

[Connor Sheehan [:sheehan]]

Attachment: Bug 1605189 - update in-tree robustcheckout with latest version r?#firefox-build-system-reviewers

This commit vendors robustcheckout from commit 584993820a97df in
version-control-tools. Updates include the removal of some dead code,
compatibility with the latest Mercurial, and Python 3 compatibility.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/94edb5d84887
update in-tree robustcheckout with latest version r=firefox-build-system-reviewers,chmanchester

Comment 3

[Noemi Erli[:noemi_erli]]

Backed out changeset 94edb5d84887 (Bug 1605189) for breaking Docker images builds CLOSED TREE

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=282114867&resultStatus=testfailed%2Cbusted%2Cexception&revision=94edb5d8488724b414452f7cca193d59609fb6a6

Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=282114838&repo=autoland&lineNumber=188
https://treeherder.mozilla.org/logviewer.html#?job_id=282115212&repo=autoland
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=282114867&repo=autoland&lineNumber=213

Backout: https://hg.mozilla.org/integration/autoland/rev/303dfa1d66c370bbfba28ae39d140c300d172580

Comment 4

[Connor Sheehan [:sheehan]]

(In reply to Noemi Erli[:noemi_erli] from comment #3)

Backed out changeset 94edb5d84887 (Bug 1605189) for breaking Docker images builds CLOSED TREE
Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=282114838&repo=autoland&lineNumber=188

This one has nothing to do with Docker image builds, and is almost certainly not related to my changes.

https://treeherder.mozilla.org/logviewer.html#?job_id=282115212&repo=autoland

The failure here has to do with a missing ip, ifconfig or ipconfig command. robustcheckout doesn't use any of these binaries - it's just a Mercurial extension. I doubt there's any relation.

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=282114867&repo=autoland&lineNumber=213

This is just a timeout connection to FF-CI taskcluster. robustcheckout has nothing to do with this.

Since robustcheckout likely isn't affecting any of these failures (or at least, if it is, I have absolutely no idea how at this time), I'm going to try and land once more. If it needs a backout I'll debug further on Monday.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b5b9d0ead3c3
update in-tree robustcheckout with latest version r=firefox-build-system-reviewers,chmanchester

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/b5b9d0ead3c3