1605191 - nsIPrincipal's IDL attributes should be camel case

Status: RESOLVED FIXED

(Core :: DOM: Security, defect, P2)

Description

[Matthew N. [:MattN]]

Attachment: Screen Shot showing the new attributes with incorrect case (and therefore sort)

The following IDL attributes were recently added as TitleCase and don't follow the tree convention which also means that the attributes are TitleCase in JS which is very unusual. We should rename them to camelCase ASAP before it becomes too hard to change them:

• AsciiOrigin
• AsciiSpec
• IsOriginPotentiallyTrustworthy
• etc.

This doesn't require changing the C++ code as the generated headers already convert it to TitleCase but this does affect JS consumers.

When choosing method names in your interface, it's best to use the interCaps style - leading lower case, subsequent units within the identifier capitalized. This matches existing JavaScript convention and will look natural to scripters.

from https://www-archive.mozilla.org/scriptable/xpidl/idl-authors-guide/best-practices

The method name used in XPIDL will appear with the same capitalization to JavaScript, so the best practice is to match JavaScript convention by declaring attributes and method names in interCaps.

from https://www-archive.mozilla.org/scriptable/xpidl/idl-authors-guide/rules

Comment 1

[Jonathan Kingston [:jkt] he/him]

Attachment: Bug 1605191 - Make nsIPrincipal attributes camelcase. r?ckerschb

Comment 2

[Jonathan Kingston [:jkt] he/him]

I think we should also consider preventing all of these interfaces as scriptable also as I can see the abuse in scripting happening and be harder to prevent.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ddcc1e78317
Make nsIPrincipal attributes camelcase. r=ckerschb

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/0ddcc1e78317

Comment 5

[Sebastian Streich [:sstreich]]

Reopened as i mistakenly added new ones that are the wrong case 🙈 sorry about that.

Comment 6

[Sebastian Streich [:sstreich]]

Attachment: Bug 1605191 - Make new nsIPrincipal attributes camelcase. r=ckerschb

Comment 7

[Boris Zbarsky [:bzbarsky]]

Don't we need to fix EqualsURI too?

Comment 8

[Sebastian Streich [:sstreich]]

yes. did update the patch, thanks for pointing out :)

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/198b3e4d5e99
Make new nsIPrincipal attributes camelcase. r=ckerschb

Comment 10

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/198b3e4d5e99