1605218 - Add telemetry for large window actor messages that we didn't send

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, task, P1)

Description

[Andrew McCreight [:mccr8]]

I'm splitting this out because I think we don't need this on beta right now.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1605218 - Add telemetry for large window actor messages that we didn't send. data-review=nshadowen

Collecting this telemetry will let us fix the large messages, if they
are common.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: data collection request

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:mccr8, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 4

[Nicole Shadowen]

Thanks for your patience.

I have a few questions in order to complete data-review.

1. Are we estimating that this collection will start now (01/06/2020) and end on 03/31/2021?
2. Is this collection opt-in for the duration for all populations - beta and nightly?
3. double-checking: Do the names of large JS window actor IPC messages we intend to collect ever contain actual categorical information about the content of the messages (in addition to operations being performed)?
4. Can the IPC message name be directly linked to the web page that might have caused it in telemetry?

Once I have these answers, I will double check with the team and complete data-review.

Feel free to message me directly on slack if it's easier to discuss. @nicole

Thanks!

Comment 5

[Andrew McCreight [:mccr8]]

(In reply to Nicole Shadowen from comment #4)

1. Are we estimating that this collection will start now (01/06/2020) and end on 03/31/2021?

I think it will end sooner than that. I set it to expire in Firefox 83, which will be in Nightly in September 2020, it looks like. This is fairly arbitrary.

2. Is this collection opt-in for the duration for all populations - beta and nightly?

From the scalars documentation it sounds like the default for "release_channel_collection" is "opt-in": "With the former the scalar is submitted by default on pre-release channels, unless the user has opted out." I guess Beta counts as pre-release?

3. double-checking: Do the names of large JS window actor IPC messages we intend to collect ever contain actual categorical information about the content of the messages (in addition to operations being performed)?

This question and the next are a little bit tricky to answer, because the message name is just a string, and they are used in a lot of places. In theory, a Firefox engineer could add whatever sort of bad thing as a message name. However, in practice I've only ever seen hard-coded strings like "Browser:CertExceptionError" that don't depend on the content of the message. I looked over the all of the places that send the message, sendAsyncMessage and sendQuery and they all seemed to be hard coded.

4. Can the IPC message name be directly linked to the web page that might have caused it in telemetry?

I can't imagine anybody actually putting URL information into a message name.

Comment 6

[Andrew McCreight [:mccr8]]

Hi, is there anything else you need from me here to move forward with the data review? Thanks.

Comment 7

[Nicole Shadowen]

Comment on attachment 9117096 [details]
data collection request

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is Telemetry so is documented in its definitions file [Scalars.yaml](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Scalars.yaml) and the [Probe Dictionary](https://telemetry.mozilla.org/probe-dictionary/).

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

No. This collection will expire in Firefox 83, which will be in Nightly in September 2020.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

    Is the data collection request for default-on or default-off?

Default-on for pre-release channels only (Beta & Nightly), default-off (opt-in) for release.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

Yes. :mccr8 is responsible for renewing or removing the collection before it expires in Firefox 83.

---
Result: datareview+

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e3c469a4ee2
Add telemetry for large window actor messages that we didn't send.  data-review=nshadowen r=jdai

Comment 9

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/2e3c469a4ee2