1605236 - Perma Linux browser/base/content/test/popupNotifications/browser_displayURI.js | Uncaught exception [...] browser_displayURI.js:105 - TypeError: content.navigator.getVRDisplays is not a function when Gecko 73 merges to beta on 2020-01-06

Status: VERIFIED FIXED

(Core :: WebVR, defect, P1)

Description

[Treeherder Bug Filer]

Filed by: archaeopteryx [at] coole-files.de
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=281921916&repo=try
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Kld79NOBSKybKId4N8zMnw/runs/0/artifacts/public/logs/live_backing.log

---

central-as-beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=281921916&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Crunning%2Cpending%2Crunnable&revision=d23b19ffbfc7c4a4d4cfcb86485ac7ac4313756a&searchStr=browser-chrome

TEST-UNEXPECTED-FAIL | browser/base/content/test/popupNotifications/browser_displayURI.js | Uncaught exception - at chrome://mochitests/content/browser/browser/base/content/test/popupNotifications/browser_displayURI.js:105 - TypeError: content.navigator.getVRDisplays is not a function

Fails because webvr is disabled for Linux on release and beta: https://searchfox.org/mozilla-central/rev/b243debf6235b050b42fd2eb615fdc729636ca6b/modules/libpref/init/StaticPrefList.yaml#2428

Comment 1

[Intermittent Failures Robot]

4 failures in 4582 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 4

Platform breakdown:

• linux64-devedition: 2
• linux64-shippable: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1605236&startday=2019-12-16&endday=2019-12-22&tree=all

Comment 2

[Arthur Iakab [arthur_iakab]]

This failure does not occur in today's central as beta sim:
https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=282403017&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=a682470a44b50c2d613e562a615a59d0b060a72e&searchStr=browser%2Cchrome

Comment 3

[Cosmin Sabou [:CosminS]]

It's still present on beta-sims: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=11f75cc87882200a3e5d6159f83608b33760137b&searchStr=browser%2Cchrome%2Clinux&selectedJob=282598750

Comment 4

[Intermittent Failures Robot]

8 failures in 1365 pushes (0.006 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 8

Platform breakdown:

• linux64-shippable: 4
• linux64-devedition: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1605236&startday=2019-12-23&endday=2019-12-29&tree=all

Comment 5

[:kip (Kearwood Gilbert)]

I'll take this. It will be fixed by bypassing the test_displayURI_xr portion of the test when dom.vr.enabled is not true.

Comment 6

[:kip (Kearwood Gilbert)]

This occurs due to dom.vr.enabled being true for Linux in Nightly but false for Linux in Beta and Release.

Comment 7

[:kip (Kearwood Gilbert)]

Attachment: Bug 1605236 - Prevent browser_displayURI.js test from testing the VR device access prompt when VR is disabled

Comment 8

[:kip (Kearwood Gilbert)]

Try push:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e7ca250cb9b7d6351044bcc6900136bbe602607f

Comment 9

[Cosmin Sabou [:CosminS]]

Kip, your patch works: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=283111820&repo=try&lineNumber=2937
Can you please ask for a review and have it landed? Thank you.

Comment 10

[:kip (Kearwood Gilbert)]

(In reply to Cosmin Sabou [:CosminS] from comment #9)

Kip, your patch works: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=283111820&repo=try&lineNumber=2937
Can you please ask for a review and have it landed? Thank you.

I found one additional part of the test that needs to be skipped when dom.vr.enabled is preffed off. This would only be causing failures in a beta simulation.

I'll have an updated patch shortly and will assign for review ASAP.

Comment 11

[:kip (Kearwood Gilbert)]

The updated patch worked locally when disabling dom.vr.enabled, and should prevent the failures in beta.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e90a1ce39bd7
Prevent browser_displayURI.js test from testing the VR device access prompt when VR is disabled r=mccr8

Comment 13

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/e90a1ce39bd7

Comment 14

[Cristina Coroiu [:ccoroiu]]

Verified as fixed with this beta sim:
https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=e91591963251f4c7fde58da8ba3400cb1a2845ac&searchStr=linux%2Cx64%2Cdevedition%2Copt%2Cmochitests%2Ctest-linux64-devedition%2Fopt-mochitest-browser-chrome-e10s-5%2Cm%28bc5%29&selectedJob=283465281