1605264 - "./mach package" should use Python 3

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Comment 1

[Ricky Stewart]

Attachment: Bug 1605264 - "./mach package" should use Python 3

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e68d872fa50
"./mach package" should use Python 3 r=firefox-build-system-reviewers,mshal

Comment 3

[Alexandru Michis [:malexandru]]

Backed out changeset 2e68d872fa50 (Bug 1605264) for causing bustages in mozapps/installer/packager.mk

Backout link: https://hg.mozilla.org/integration/autoland/rev/3e3f369281af9546bf54a72cdadcbf5f9a2d9efe

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&tochange=3e3f369281af9546bf54a72cdadcbf5f9a2d9efe&searchStr=os%2Cx%2Ccross%2Ccompiled%2Casan%2Cbuild-macosx64-asan-fuzzing%2Fopt%2C%28bof%29&fromchange=c8833adba54fc6b24c66b5f52bfb9444087d41cc&selectedJob=283073998

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=283073471&repo=autoland&lineNumber=41328

[task 2019-12-31T19:39:20.630Z] 19:39:20 INFO - package> Rewriting ASan runtime dylib paths for all binaries in ../../dist/firefox/Nightly.app/Contents/MacOS ...
[task 2019-12-31T19:39:20.630Z] 19:39:20 INFO - package> /builds/worker/workspace/build/src/obj-firefox/_virtualenvs/init_py3/bin/python /builds/worker/workspace/build/src/build/unix/rewrite_asan_dylib.py ../../dist/firefox/Nightly.app/Contents/MacOS
[task 2019-12-31T19:39:20.630Z] 19:39:20 ERROR - package> Traceback (most recent call last):
[task 2019-12-31T19:39:20.630Z] 19:39:20 INFO - package> File "/builds/worker/workspace/build/src/build/unix/rewrite_asan_dylib.py", line 117, in <module>
[task 2019-12-31T19:39:20.631Z] 19:39:20 INFO - package> scan_directory(d)
[task 2019-12-31T19:39:20.631Z] 19:39:20 INFO - package> File "/builds/worker/workspace/build/src/build/unix/rewrite_asan_dylib.py", line 71, in scan_directory
[task 2019-12-31T19:39:20.631Z] 19:39:20 INFO - package> if DYLIB_NAME in line:
[task 2019-12-31T19:39:20.631Z] 19:39:20 ERROR - package> TypeError: a bytes-like object is required, not 'str'
[task 2019-12-31T19:39:20.631Z] 19:39:20 INFO - package> /builds/worker/workspace/build/src/toolkit/mozapps/installer/packager.mk:25: recipe for target 'stage-package' failed
[task 2019-12-31T19:39:20.631Z] 19:39:20 ERROR - package> make[5]: *** [stage-package] Error 1
[task 2019-12-31T19:39:20.631Z] 19:39:20 INFO - package> make[5]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/browser/installer'
[task 2019-12-31T19:39:20.631Z] 19:39:20 INFO - package> /builds/worker/workspace/build/src/toolkit/mozapps/installer/packager.mk:108: recipe for target 'make-package' failed
[task 2019-12-31T19:39:20.631Z] 19:39:20 ERROR - package> make[4]: *** [make-package] Error 2
[task 2019-12-31T19:39:20.631Z] 19:39:20 INFO - package> /builds/worker/workspace/build/src/config/rules.mk:394: recipe for target 'default' failed
[task 2019-12-31T19:39:20.631Z] 19:39:20 ERROR - package> make[3]: *** [default] Error 2
[task 2019-12-31T19:39:20.631Z] 19:39:20 INFO - package> /builds/worker/workspace/build/src/browser/build.mk:6: recipe for target 'package' failed
[task 2019-12-31T19:39:20.631Z] 19:39:20 ERROR - package> make[2]: *** [package] Error 2
[task 2019-12-31T19:39:20.631Z] 19:39:20 INFO - /builds/worker/workspace/build/src/build/moz-automation.mk:112: recipe for target 'automation/package' failed
[task 2019-12-31T19:39:20.631Z] 19:39:20 ERROR - make[1]: *** [automation/package] Error 2
[task 2019-12-31T19:39:20.631Z] 19:39:20 INFO - client.mk:129: recipe for target 'build' failed
[task 2019-12-31T19:39:20.632Z] 19:39:20 INFO - make: *** [build] Error 2
[task 2019-12-31T19:39:20.667Z] 19:39:20 INFO - 354 compiler warnings present.
[task 2019-12-31T19:39:20.797Z] 19:39:20 ERROR - Return code: 2
[task 2019-12-31T19:39:20.797Z] 19:39:20 WARNING - setting return code to 2
[task 2019-12-31T19:39:20.797Z] 19:39:20 FATAL - 'mach build -v' did not run successfully. Please check log for errors.
[task 2019-12-31T19:39:20.797Z] 19:39:20 FATAL - Running post_fatal callback...
[task 2019-12-31T19:39:20.797Z] 19:39:20 FATAL - Exiting -1

Comment 4

[Ricky Stewart]

The build-macosx64-asan-fuzzing/opt build is failing after this patch, but luckily every other build seems fine. I'm going to verify that one works and then re-land this.

Comment 5

[Ricky Stewart]

Successful try push: https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=283077987&revision=3f9fc91cbcf450c92e56f590e017ed3fdd6dc511

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe3a47b458ad
"./mach package" should use Python 3 r=firefox-build-system-reviewers,mshal

Comment 7

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/fe3a47b458ad

Comment 8

[Andrei Ciure[:aciure]]

Backed out changeset fe3a47b458ad (bug 1605264) for causing build bustages on central

failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&selectedJob=283120392&resultStatus=busted%2Crunnable&revision=3756a5e51a3d1b2e17c0802418a6857f9b6b2172

backout: https://hg.mozilla.org/mozilla-central/rev/45157f104e45f2f7725448e85f61d45c3d3f8655

Comment 9

[Ricky Stewart]

I'll re-land this (hopefully for the last time) after the try push for these jobs succeeds.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/acc8cae5b23f
"./mach package" should use Python 3 r=firefox-build-system-reviewers,mshal

Comment 11

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/acc8cae5b23f