Closed Bug 1605297 Opened 4 years ago Closed 4 years ago

Intermittent browser/extensions/doh-rollout/test/browser/browser_policyOverride.js | Uncaught exception - undefined - timed out after 50 tries.

Categories

(Firefox :: Security, defect, P5)

defect

Tracking

()

RESOLVED FIXED
Tracking Status
firefox73 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: nhnt11)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: intermittent-failure, regression, Whiteboard: [retriggered][stockwell disabled])

Attachments

(2 files, 2 obsolete files)

Filed by: rmaries [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=282033576&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/GaSxCXqkRomtlyXokwhzLA/runs/0/artifacts/public/logs/live_backing.log


[task 2019-12-20T03:18:09.482Z] 03:18:09 INFO - TEST-START | browser/extensions/doh-rollout/test/browser/browser_policyOverride.js
[task 2019-12-20T03:18:17.610Z] 03:18:17 INFO - TEST-INFO | started process screencapture
[task 2019-12-20T03:18:17.792Z] 03:18:17 INFO - TEST-INFO | screencapture: exit 0
[task 2019-12-20T03:18:17.792Z] 03:18:17 INFO - Buffered messages logged at 03:18:09
[task 2019-12-20T03:18:17.792Z] 03:18:17 INFO - Entering test bound testPolicyOverride
[task 2019-12-20T03:18:17.792Z] 03:18:17 INFO - TEST-PASS | browser/extensions/doh-rollout/test/browser/browser_policyOverride.js | Sanity check the temporary file doesn't exist. - true == true -
[task 2019-12-20T03:18:17.792Z] 03:18:17 INFO - TEST-PASS | browser/extensions/doh-rollout/test/browser/browser_policyOverride.js | Policy engine is active. -
[task 2019-12-20T03:18:17.792Z] 03:18:17 INFO - Buffered messages finished
[task 2019-12-20T03:18:17.793Z] 03:18:17 INFO - TEST-UNEXPECTED-FAIL | browser/extensions/doh-rollout/test/browser/browser_policyOverride.js | Uncaught exception - undefined - timed out after 50 tries.
[task 2019-12-20T03:18:17.793Z] 03:18:17 INFO - Leaving test bound testPolicyOverride
[task 2019-12-20T03:18:17.793Z] 03:18:17 INFO - GECKO(2044) | MEMORY STAT | vsize 7594MB | residentFast 308MB | heapAllocated 93MB
[task 2019-12-20T03:18:17.793Z] 03:18:17 INFO - TEST-OK | browser/extensions/doh-rollout/test/browser/browser_policyOverride.js | took 8142ms
[task 2019-12-20T03:18:17.793Z] 03:18:17 INFO - checking window state

I think https://hg.mozilla.org/integration/autoland/rev/f92d4db5d7e4 is the culprit.

Nihanth, could you take a look?

Flags: needinfo?(nhnt11)
Regressed by: 1598221
Has Regression Range: --- → yes
Keywords: regression

Retrigger results confirm Razvan's comment above

Whiteboard: [retriggered]

I'll dig into this tomorrow. Took a quick look today and the problem was not obvious.

Flags: needinfo?(nhnt11)
Assignee: nobody → nhnt11
Status: NEW → ASSIGNED

Nihanth, this made it to the disable list, with 122 failures in the last 21 days: https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?startday=2019-12-08&endday=2019-12-29&tree=trunk&bug=1605297
Please let us know if you want us to disable this test or if you can fix it.

Flags: needinfo?(nhnt11)
Attachment #9117993 - Attachment is obsolete: true

Working on it today, but please go ahead and disable it if this is crossing our failure-rate thresholds.

Flags: needinfo?(nhnt11)

There was a race between the add-on adding its pref listener and us flipping the enabled pref. By waiting for
the balrog migration, we give the add-on time to start listening for the pref before setting it.

Whiteboard: [retriggered][stockwell disable-recommended] → [stockwell needswork][retriggered]
Pushed by nhnt11@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b2027d7f6480
Wait for balrog migration at test start to prevent intermittent failures in DoH tests. r=JuniorHsu
Backout by nerli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/eee9db89e4a7
Backed out changeset b2027d7f6480 for failures in browser_cleanFlow.js CLOSED TREE
Pushed by dvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bbf630f15308
disable browser_policyOverride.js for frequent failures. r=jmaher
Keywords: leave-open
Whiteboard: [retriggered][stockwell disable-recommended] → [retriggered][stockwell disabled]
Pushed by nhnt11@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/2a0d5d66eb16
Don't expect telemetry after restarting add-on in policy override test. r=johannh

This applies cleanly on beta rev https://hg.mozilla.org/releases/mozilla-beta/rev/d3ab563a434bfafa13aaad2dcde764104367336a.
Nihanth, could you please submit an uplift request for rev in comment 33 to get rid of the permafails in browser_policyOverride on beta? Thank you.

Flags: needinfo?(nhnt11)
Flags: needinfo?(dd.mozilla)
Flags: needinfo?(nhnt11)

Comment on attachment 9122571 [details]
Bug 1605297 - Don't expect telemetry after restarting add-on in policy override test. r=johannh!

Beta/Release Uplift Approval Request

  • User impact if declined: None
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This fixes a permafailing test. The fix has been verified. It's a one-line change in a test script. No user-facing code touched.
  • String changes made/needed:
Flags: needinfo?(nhnt11)
Attachment #9122571 - Flags: approval-mozilla-beta?

Comment on attachment 9122571 [details]
Bug 1605297 - Don't expect telemetry after restarting add-on in policy override test. r=johannh!

test-only change, doesn't need approval.

Attachment #9122571 - Flags: approval-mozilla-beta?
Whiteboard: [retriggered][stockwell disabled] → [checkin-needed-beta][retriggered][stockwell disabled]
Whiteboard: [checkin-needed-beta][retriggered][stockwell disabled] → [retriggered][stockwell disabled]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: General → Security
Attachment #9118143 - Attachment is obsolete: true

The DoH heuristics code was ported into a JS component, and several mechanics reworked. The tests live in a new directory and have all been re-enabled, and I'd like to track any new intermittents in new bugs. Closing all open intermittent test failure bugs associated with the old extension.

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: