1605342 - Enable RDM meta viewport handling in 73, after the gradual roll-out which happens in 72

Status: VERIFIED FIXED

(DevTools :: Responsive Design Mode, enhancement)

Description

[Patrick Brosset <:pbro>]

After bug 1594948 is done, the RDM meta viewport handling feature will have been gradually rolled out in 72 release, we will need to enable the feature for real on all channels starting in 73.

Comment 1

[Patrick Brosset <:pbro>]

Attachment: Bug 1605342 - Let RDM's metaviewport handling ride the trains

After the gradual rollout of the feature in 72, we can turn it on for all users

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/141078286511
Let RDM's metaviewport handling ride the trains r=bradwerth

Comment 3

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/141078286511

Comment 4

[Patrick Brosset <:pbro>]

Comment on attachment 9119092 [details]
Bug 1605342 - Let RDM's metaviewport handling ride the trains

Beta/Release Uplift Approval Request

• User impact if declined: The metaviewport handling feature is being rolled out in 72. So when 73 comes, we need the feature to also be ON.
  It's easy enough to turn it back off with another uplift later if really the roll-out was to discover some important problems. But for now, we have every reason to believe it is solid and stable, and we want it to spend as much time in beta being ON.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce: QA already done in beta 72.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The change itself is just a pref value.
• String changes made/needed:

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9119092 [details]
Bug 1605342 - Let RDM's metaviewport handling ride the trains

Makes the RDM's metaviewport handling default to on in support of the phased rollout in 72. Approved for 73.0b3.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

I think QA should at least verify that this is on by default as expected.

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a5b2a67d0d01

Comment 8

[Alin Ilea, Desktop Test Engineering]

Verified - Fixed in latest Nightly build 74.0a1 (Build id: 20200114214307) and latest Beta 73.0b5 (Build id: 20200115020958). The RDM's metaviewport pref is on by default.