BMO_CHECK hook is too aggressive about matching bug numbers
Categories
(Developer Services :: Mercurial: hg.mozilla.org, defect)
Tracking
(Not tracked)
People
(Reporter: jgraham, Assigned: zeid)
References
Details
The wptsync bot just tried to make a try push involving a commit that originated in Chrome with a line like
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958692
https://hg.mozilla.org/try/rev/3d36f1bacaf32fdf776f73218557e1b3004526cb
This was rejected for 1958692 not being a valid bug number.
This is pretty common in wpt sync PRs; we get references to bug numbers in other systems that therefore aren't gecko bug numbers. In the short term I'm going to have to add SKIP_BMO_CHECK to all the commits that the sync pushes, which isn't ideal.
If we could just verify the bug at the start of the summary is valid and that anything with a bmo link is a valid bug number, that would avoid this kind of annoying false-positive.
|
Assignee | |
Updated•6 years ago
|
|
||
Comment 1•6 years ago
|
||
Looks like we might be hitting the same problem as in bug 1482236. Maybe we're matching too liberally on whitespace for that regular expression?
|
|
Assignee | |
Comment 2•6 years ago
|
||
Marking this as duplicate of bug 1605656, as both will be solved with the same solution.
Description
•