1605368 - Use is() instead of ok() when comparing values in browser_application_panel_manifest-display.js

Status: RESOLVED FIXED

(DevTools :: Application Panel, task, P3)

Description

[Julian Descottes [:jdescottes]]

https://searchfox.org/mozilla-central/rev/b243debf6235b050b42fd2eb615fdc729636ca6b/devtools/client/application/test/browser/browser_application_panel_manifest-display.js#116-119,137-141

Two spots are using ok to compare test values:

  ok(
    imgEl && imgEl.src === URL_ROOT + "resources/manifest/icon.svg",
    "An image is being displayed with the icon url as source"
  );
// ...
  ok(
    itemEl.querySelector(".js-manifest-item-content").textContent ===
      expectedValue,
    `Manifest member ${member} is being displayed with value ${expectedValue}`
  );

While this works fine, in case you get a failure, the logs will not include the expected & test value automatically. Using the is helper takes care of this.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1605368 - Use is() instead of ok() in some asserts of browser_application_panel_manifest-display.js

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/11720a001804
Use is() instead of ok() in some asserts of browser_application_panel_manifest-display.js r=ladybenko

Comment 3

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/11720a001804