1605383 - [Firefox "ru" locale] The placeholder text from the in-content "Search Bar" overlaps the field's borders if the browser is resized under 30% and the page is scrolled down

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: rec of the issue.gif

[Affected versions]:

• Firefox Nightly 73.0a1 - Build ID: 20191220095035

[Affected Platforms]:

• Windows 10 x64
• Mac 10.15.1
• Ubuntu 18.04 x64

[Prerequisites]:

• Have the latest Firefox Nighlty 73.0a1 "ru" locale build installed.

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites.
2. Horizontally resize the browser below 30%.
3. Scroll down and observe the in-content "Search Bar".

[Expected result]:

• All the elements are correctly resized and rendered.

[Actual result]:

• The placeholder text overlaps the "Search" field's borders.

[Notes]:

• This issue is also reproducible with the old "Activity Stream" experience.
• Attached a screen recording of the issue.

Comment 1

[Jessilyn Davis]

Tyler and Gavin to sync on this. Potentially uplift into Beta 73 if it's small.

Comment 2

[Gavin Suntop [:gvn] (they/them)]

Attachment: using minheights on searchbox to allow longer translations

Comment 3

[Gavin Suntop [:gvn] (they/them)]

Attachment: searchbox with patch

Comment 4

[Gavin Suntop [:gvn] (they/them)]

@Tyler, Scott has filed a new bug with some refinement ideas, so if you have further feedback that'd be a good place.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa02843c2453
using minheights on searchbox to allow longer translations r=thecount

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/aa02843c2453

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval. It grafts cleanly as-landed.

Comment 8

[Gavin Suntop [:gvn] (they/them)]

Comment on attachment 9119835 [details]
using minheights on searchbox to allow longer translations

Beta/Release Uplift Approval Request

• User impact if declined: Some translations of the searchbox help text will overflow the searchbox container in a narrow width browser window.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See ticket.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Existing base heights are not changing, only being changed to minimums. The containers can now scale larger to accommodate longer text.
• String changes made/needed: None

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9119835 [details]
using minheights on searchbox to allow longer translations

Simple cosmetic fix. Approved for 73.0b4.

Comment 10

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2d320c5776f4

Comment 11

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly RU locale (74.0a1 Build ID - 20200113204142) and with the latest Firefox Beta 73.0b4 RU locale installed, on Windows 10 x64, Ubuntu 18.04 x64 and Mac 10.15.2. Now, the placeholder text from the in-content "Search Bar" no longer overlaps the field's borders.