1605403 - UserScriptOptions js property shouldn't be optional

Status: RESOLVED FIXED

(WebExtensions :: General, defect, P5)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

The js property is currently marked as optional in the API schema file, as it is in the RegisteredContentScriptOptions related to the contentScripts API.

For the contentScripts the js property is optional because an extension may register a CSS only contentScript, but it doesn't make much sense to register a userScript without any associated script and so it would make sense to make the js property mandatory for userScripts.register.

Comment 1

[Atique Ahmed Ziad [:atiqueahmedziad]]

Hello Luca,

I want to work on it. I haven't worked on webExtension bugs earlier. Can you give me some instruction, how will I submit a patch for this bug ?

Thanks
Atique

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

(In reply to Atique Ahmed Ziad [:atiqueahmedziad] from comment #1)

Hello Luca,

I want to work on it. I haven't worked on webExtension bugs earlier. Can you give me some instruction, how will I submit a patch for this bug ?

Thanks
Atique

Hi Atique!
Some documentation on contributing to the WebExtensions API is available at https://wiki.mozilla.org/WebExtensions/Contribution_Onramp

Once your development environment setup is done, comment 0 includes a link to the part of the user_scripts.json API schema file relevant to this issue.

It would be good to also add a test case that covers the fix to the API JSON schema, by adding a new test case to the userScripts tests that verify that the js property is not optional and browser.userScripts.register fails as expected when called without it.

The main group of test cases related to the userScripts API is in the toolkit/components/extensions/test/xpcshell/test_ext_userScripts.js test file.

Comment 3

[Atique Ahmed Ziad [:atiqueahmedziad]]

Attachment: Bug 1605403 - UserScriptOptions js property shouldn't be optional. r=rpl

Comment 4

[Atique Ahmed Ziad [:atiqueahmedziad]]

Attachment: Bug 1605403 - UserScriptOptions js property shouldn't be optional. r=rpl

Depends on D60996

Comment 5

[Luca Greco [:rpl] [:luca] [:lgreco]]

Comment on attachment 9122941 [details]
Bug 1605403 - UserScriptOptions js property shouldn't be optional. r=rpl

Marking as obsolete (this patch is being abandoned in favor of D61002, which now includes the content originally split in the two phabricator revisions).

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/80ae1b003c69
UserScriptOptions js property shouldn't be optional. r=rpl

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/80ae1b003c69