1605545 - Memory leak in Pk11Install_Platform_Generate

Status: RESOLVED FIXED

(NSS :: Tools, defect)

Description

[Alex Henrie]

Pk11Install_Platform_Generate currently has the following block of code:

if (errStr) {
    tmp = PR_smprintf("%s: %s",
                      Pk11Install_PlatformName_GetString(&_this->name), errStr);
    tmp = PR_smprintf("%s: %s",
                      Pk11Install_PlatformName_GetString(&_this->name), errStr);
    PR_smprintf_free(errStr);
    errStr = tmp;
    goto loser;
}

The value returned by PR_smprintf is overwritten without being freed by PR_smprintf_free. There doesn't seem to be any reason to call PR_smprintf twice with the same arguments; it looks like a copy-paste error.

Comment 1

[Alex Henrie]

Attachment: Bug 1605545 - Fix memory leak in Pk11Install_Platform_Generate.

Comment 2

[J.C. Jones [:jcj] (he/him)]

https://hg.mozilla.org/projects/nss/rev/748b308170a4092cbb98a6577d4a16e8956452b2