Closed Bug 1605545 Opened 2 years ago Closed 2 years ago

Memory leak in Pk11Install_Platform_Generate

Categories

(NSS :: Tools, defect)

3.48
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: alexhenrie24, Assigned: alexhenrie24)

Details

Attachments

(1 file)

Pk11Install_Platform_Generate currently has the following block of code:

if (errStr) {
    tmp = PR_smprintf("%s: %s",
                      Pk11Install_PlatformName_GetString(&_this->name), errStr);
    tmp = PR_smprintf("%s: %s",
                      Pk11Install_PlatformName_GetString(&_this->name), errStr);
    PR_smprintf_free(errStr);
    errStr = tmp;
    goto loser;
}

The value returned by PR_smprintf is overwritten without being freed by PR_smprintf_free. There doesn't seem to be any reason to call PR_smprintf twice with the same arguments; it looks like a copy-paste error.

Assignee: nobody → alexhenrie24
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.