1605566 - MessagePort should support wasm modules and SharedArrayBuffer when possible

Status: RESOLVED FIXED

(Core :: DOM: postMessage, task)

Description

[Andrea Marchesini [:baku]]

We don't support the sending of WasmModules and SharedArrayBuffer via MessagePort because, in theory, ports work between processes. But this scenario is extremely rare and it requires the user sharedWorkers, which are not so common yet.

I want to suggest a different approach where we support the serialization of everything for normal scenarios and, on the remote occasion the messaging is cross-process, we dispatch a messageerror event.

This is compatible with the current spec definition.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: Bug 1605566 - MessagePort + wasm - part 1 - Implement JS_DetectScopeStructuredClone, r?sfink

Comment 2

[Andrea Marchesini [:baku]]

Attachment: Bug 1605566 - MessagePort + wasm - part 2 - Implement StructuredCloneHolder::DetectScope, r?smaug

Depends on D58077

Comment 3

[Andrea Marchesini [:baku]]

Attachment: Bug 1605566 - MessagePort + wasm - part 3 - MessagePort serializes objects using MessageData union, r?smaug

Depends on D58078

Comment 4

[Andrea Marchesini [:baku]]

Attachment: Bug 1605566 - MessagePort + wasm - part 4 - Implement RefMessageBodyService, r?smaug

Depends on D58079

Comment 5

[Andrea Marchesini [:baku]]

Attachment: Bug 1605566 - MessagePort + wasm - part 5 - tests, r?smaug

Depends on D58080

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Could you explain where messageerror gets dispatched?

Comment 7

[Andrea Marchesini [:baku]]

By spec, messageerror is dispatched if the deserialization fails:

https://html.spec.whatwg.org/multipage/web-messaging.html#message-port-post-message-steps
7.3:

Let deserializeRecord be StructuredDeserializeWithTransfer(serializeWithTransferResult, targetRealm).
If this throws an exception, catch it, fire an event named messageerror at finalTargetPort, using MessageEvent, and then return.

In my code, this happens when the MessagePort receives a RefMessageBody ID from a different process.

Comment 8

[Andrea Marchesini [:baku]]

Attachment: Bug 1605566 - MessagePort + wasm - part 1 - access scope via method in StructuredClone code, r?sfink

Comment 9

[Andrea Marchesini [:baku]]

Attachment: Bug 1605566 - MessagePort + wasm - part 2 - implement JS::StructuredCloneScope::UnknownDestination, r?sfink

Depends on D59612

Comment 10

[Andrea Marchesini [:baku]]

Attachment: Bug 1605566 - MessagePort + wasm - part 3 - MessagePort serializes objects using MessageData union, r?smaug

Depends on D59613

Comment 11

[Andrea Marchesini [:baku]]

Attachment: Bug 1605566 - MessagePort + wasm - part 4 - Implement RefMessageBodyService, r?smaug

Depends on D59614

Comment 12

[Andrea Marchesini [:baku]]

Attachment: Bug 1605566 - MessagePort + wasm - part 5 - tests, r?smaug

Depends on D59615

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/37026beadbd8
MessagePort + wasm - part 1 - access scope via method in StructuredClone code, r=sfink
https://hg.mozilla.org/integration/autoland/rev/554b2bdce66c
MessagePort + wasm - part 2 - implement JS::StructuredCloneScope::UnknownDestination, r=sfink
https://hg.mozilla.org/integration/autoland/rev/36631ec96f1f
MessagePort + wasm - part 3 - MessagePort serializes objects using MessageData union, r=smaug
https://hg.mozilla.org/integration/autoland/rev/3427a92445c8
MessagePort + wasm - part 4 - Implement RefMessageBodyService, r=smaug
https://hg.mozilla.org/integration/autoland/rev/39f34852842e
MessagePort + wasm - part 5 - tests, r=smaug

Comment 14

[Alexandru Michis [:malexandru]]

Backed out 9 changesets (Bug 1607791, Bug 1605566) for causing multiple wpt failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/0bb7d315058732b15df19fb8648fa634d92a481e

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&collapsedPushes=598800&group_state=expanded&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception&tochange=0bb7d315058732b15df19fb8648fa634d92a481e&fromchange=39f34852842e1d58860156cba9bc05e8a133a27a&searchStr=wpt&selectedJob=285018926

Failure logs:

• https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=285018926&repo=autoland&lineNumber=6096
• https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=285018957&repo=autoland&lineNumber=5026

Comment 15

[Andrea Marchesini [:baku]]

Attachment: Bug 1605566 - MessagePort + wasm - part 6 - agent cluster ID, r?smaug

Comment 16

[Andrea Marchesini [:baku]]

Attachment: Bug 1605566 - MessagePort + wasm - part 6 - workaround for GeckoView, r?smaug

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/77bdf4f86052
MessagePort + wasm - part 1 - access scope via method in StructuredClone code, r=sfink
https://hg.mozilla.org/integration/autoland/rev/99f61f25ed86
MessagePort + wasm - part 2 - implement JS::StructuredCloneScope::UnknownDestination, r=sfink
https://hg.mozilla.org/integration/autoland/rev/7eab8fd2b62e
MessagePort + wasm - part 3 - MessagePort serializes objects using MessageData union, r=smaug
https://hg.mozilla.org/integration/autoland/rev/ab98304e6c84
MessagePort + wasm - part 4 - Implement RefMessageBodyService, r=smaug
https://hg.mozilla.org/integration/autoland/rev/622939cef438
MessagePort + wasm - part 5 - tests, r=smaug

Comment 19

[Oana Pop-Rus]

Backed out 5 changesets (bug 1605566) for wpt failures on shared.html

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=285934381&resultStatus=pending%2Crunning%2Csuccess%2Csuperseded%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&searchStr=android%2C7.0%2Cx86-64%2Copt%2Cweb%2Cplatform%2Ctests%2Ctest-android-em-7.0-x86_64%2Fopt-geckoview-web-platform-tests-e10s-12%2Cw%28wpt12%29&revision=622939cef4384b52af85ae62e8a60627f686c5cf

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=285934381&repo=autoland&lineNumber=5039

Backout: https://hg.mozilla.org/integration/autoland/rev/74493854a1b6478d5a9c3674df1369788783eeee

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0f4082f969d
MessagePort + wasm - part 1 - access scope via method in StructuredClone code, r=sfink
https://hg.mozilla.org/integration/autoland/rev/9ccdf46d9dd4
MessagePort + wasm - part 2 - implement JS::StructuredCloneScope::UnknownDestination, r=sfink
https://hg.mozilla.org/integration/autoland/rev/b55456d966a4
MessagePort + wasm - part 3 - MessagePort serializes objects using MessageData union, r=smaug
https://hg.mozilla.org/integration/autoland/rev/be8a9e4029f6
MessagePort + wasm - part 4 - Implement RefMessageBodyService, r=smaug
https://hg.mozilla.org/integration/autoland/rev/a7d7f6d229c8
MessagePort + wasm - part 5 - tests, r=smaug

Comment 21

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/d0f4082f969d
https://hg.mozilla.org/mozilla-central/rev/9ccdf46d9dd4
https://hg.mozilla.org/mozilla-central/rev/b55456d966a4
https://hg.mozilla.org/mozilla-central/rev/be8a9e4029f6
https://hg.mozilla.org/mozilla-central/rev/a7d7f6d229c8