Closed Bug 1605650 Opened 4 years ago Closed 3 years ago

Perma win ccov remote/cdp/test/browser/network/browser_getCookies.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. -

Categories

(Remote Protocol :: CDP, defect, P5)

Product:
Remote Protocol
Component:
CDP
Type:
defect

Tracking

(firefox-esr91 disabled, firefox72 unaffected, firefox73 disabled, firefox95 disabled, firefox96 fixed)

Status:
RESOLVED FIXED
Milestone:
96 Branch
Tracking Flags:
Tracking Status
firefox-esr91 --- disabled
firefox72 --- unaffected
firefox73 --- disabled
firefox95 --- disabled
firefox96 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: whimboo)

References

Details

(Keywords: intermittent-failure)

Attachments

(3 files)

Bug 1605650 - [remote] Temporarily skip test browser_getCookies.js for ccov tests on Windows 10.
47 bytes, text/x-phabricator-request
Details | Review
Bug 1605650 - [remote] Enable mochitest-remote jobs for Windows CCOV builds. r?jmaher
48 bytes, text/x-phabricator-request
Details | Review
Bug 1605650 - [remote] Re-enable browser_getCookies.js for Windows CCOV builds.
48 bytes, text/x-phabricator-request
Details | Review

Filed by: apavel [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=282337858&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/J5pR2bJCQ-ytCjxd0MbbJQ/runs/0/artifacts/public/logs/live_backing.log

[task 2019-12-22T15:17:11.358Z] 15:17:11 INFO - TEST-START | remote/test/browser/network/browser_getCookies.js
[task 2019-12-22T15:17:11.727Z] 15:17:11 INFO - GECKO(6236) | [Parent 1912: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 00000260B0F4A800 == 6 [pid = 1912] [id = {750251f8-e77c-451c-ac58-d2d9792120e7}]
[task 2019-12-22T15:17:11.727Z] 15:17:11 INFO - GECKO(6236) | [Parent 1912: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 15 (00000260B79DDC40) [pid = 1912] [serial = 15] [outer = 0000000000000000]
[task 2019-12-22T15:17:11.727Z] 15:17:11 INFO - GECKO(6236) | [Parent 1912: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 16 (00000260B778E800) [pid = 1912] [serial = 16] [outer = 00000260B79DDC40]
[task 2019-12-22T15:17:11.746Z] 15:17:11 INFO - GECKO(6236) | [Parent 1912: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 17 (00000260B7793C00) [pid = 1912] [serial = 17] [outer = 00000260B79DDC40]
[task 2019-12-22T15:17:12.230Z] 15:17:12 INFO - GECKO(6236) | [Parent 1912, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, nullptr) failed with result 0x804B000A: file z:/build/build/src/extensions/permissions/nsPermission.cpp, line 45
[task 2019-12-22T15:17:12.230Z] 15:17:12 INFO - GECKO(6236) | [Parent 1912, Main Thread] WARNING: NS_ENSURE_TRUE(principal) failed: file z:/build/build/src/extensions/permissions/nsPermission.cpp, line 57
[task 2019-12-22T15:17:12.230Z] 15:17:12 INFO - GECKO(6236) | [Parent 1912, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, nullptr) failed with result 0x804B000A: file z:/build/build/src/extensions/permissions/nsPermission.cpp, line 45
[task 2019-12-22T15:17:12.230Z] 15:17:12 INFO - GECKO(6236) | [Parent 1912, Main Thread] WARNING: NS_ENSURE_TRUE(principal) failed: file z:/build/build/src/extensions/permissions/nsPermission.cpp, line 57
[task 2019-12-22T15:17:12.288Z] 15:17:12 INFO - GECKO(6236) | DLL blocklist was unable to intercept AppInit DLLs.
[task 2019-12-22T15:17:12.298Z] 15:17:12 INFO - GECKO(6236) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to c:\users\task_1577025280\appdata\local\temp\tmp3kroz3.mozrunner\runtests_leaks_tab_pid4836.log

[task 2019-12-22T15:18:48.797Z] 15:18:48 INFO - TEST-PASS | remote/test/browser/network/browser_getCookies.js | A single cookie has been found -
[task 2019-12-22T15:18:48.797Z] 15:18:48 INFO - TEST-PASS | remote/test/browser/network/browser_getCookies.js | {"name":"foo","value":"bar","domain":"example.org","path":"/","expires":-1,"size":6,"httpOnly":false,"secure":false,"session":true,"sameSite":"Lax"} deepEqual {"name":"foo","value":"bar","domain":"example.org","path":"/","expires":-1,"size":6,"httpOnly":false,"secure":false,"session":true,"sameSite":"Lax"} -
[task 2019-12-22T15:18:48.797Z] 15:18:48 INFO - TEST-PASS | remote/test/browser/network/browser_getCookies.js | A single cookie has been found -
[task 2019-12-22T15:18:48.797Z] 15:18:48 INFO - TEST-PASS | remote/test/browser/network/browser_getCookies.js | {"name":"foo","value":"bar","domain":"example.org","path":"/","expires":-1,"size":6,"httpOnly":false,"secure":false,"session":true,"sameSite":"Strict"} deepEqual {"name":"foo","value":"bar","domain":"example.org","path":"/","expires":-1,"size":6,"httpOnly":false,"secure":false,"session":true,"sameSite":"Strict"} -
[task 2019-12-22T15:18:48.797Z] 15:18:48 INFO - Buffered messages logged at 15:18:48
[task 2019-12-22T15:18:48.798Z] 15:18:48 INFO - CDP client closed
[task 2019-12-22T15:18:48.798Z] 15:18:48 INFO - CDP server stopped
[task 2019-12-22T15:18:48.798Z] 15:18:48 INFO - Leaving test bound sameSite
[task 2019-12-22T15:18:48.798Z] 15:18:48 INFO - Buffered messages finished
[task 2019-12-22T15:18:48.798Z] 15:18:48 INFO - TEST-UNEXPECTED-FAIL | remote/test/browser/network/browser_getCookies.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. -
[task 2019-12-22T15:18:48.798Z] 15:18:48 INFO - GECKO(6236) | MEMORY STAT | vsize 2104572MB | vsizeMaxContiguous 67440761MB | residentFast 427MB | heapAllocated 129MB
[task 2019-12-22T15:18:48.798Z] 15:18:48 INFO - TEST-OK | remote/test/browser/network/browser_getCookies.js | took 97415ms
[task 2019-12-22T15:18:48.799Z] 15:18:48 INFO - GECKO(6236) | [Child 4836: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 000001F5BAA7C000 == 2 [pid = 4836] [id = {8767e9cf-521c-42ca-8426-c4037398f76a}]
[task 2019-12-22T15:18:48.799Z] 15:18:48 INFO - GECKO(6236) | [Child 4836: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 6 (000001F5BED1B7A0) [pid = 4836] [serial = 25] [outer = 0000000000000000]
[task 2019-12-22T15:18:48.799Z] 15:18:48 INFO - GECKO(6236) | [Child 4836: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 7 (000001F5BEDC2C00) [pid = 4836] [serial = 26] [outer = 000001F5BED1B7A0]
[task 2019-12-22T15:18:48.850Z] 15:18:48 INFO - GECKO(6236) | [Child 4836: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 8 (000001F5BFCAD000) [pid = 4836] [serial = 27] [outer = 000001F5BED1B7A0]
[task 2019-12-22T15:18:48.850Z] 15:18:48 INFO - checking window state

Blocks: 1590098
Summary: Intermittent remote/test/browser/network/browser_getCookies.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. - → Intermittent win ccov remote/test/browser/network/browser_getCookies.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. -
See Also: → 1605782
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → DUPLICATE
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Summary: Intermittent win ccov remote/test/browser/network/browser_getCookies.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. - → Intermittent win remote/test/browser/network/browser_getCookies.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. -

Hi Marco, any idea why the ccov build is that slow here when interacting with the cookie service? The tests are pretty basic and I don't see why it causes such timeouts.

For now I will temporarily skip the test for ccov builds on Windows, which is what this bug actually covers.

Status: REOPENED → NEW
Flags: needinfo?(mcastelluccio)
Summary: Intermittent win remote/test/browser/network/browser_getCookies.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. - → Perma win ccov remote/test/browser/network/browser_getCookies.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. -

I have no idea :(
Hopefully switching to an opt build will help (bug 1457392), otherwise we can try profiling.

Flags: needinfo?(mcastelluccio)

Ok, for now I will just disable the test for ccov.

Depends on: 1457392
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Assignee: hskupin → nobody
Status: ASSIGNED → NEW
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Status: ASSIGNED → NEW
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/90cec6ee12ac
[remote] Temporarily skip test browser_getCookies.js for ccov tests on Windows 10. r=remote-protocol-reviewers,ato
Assignee: hskupin → nobody
Keywords: leave-open, test-disabled
Summary: Perma win ccov remote/test/browser/network/browser_getCookies.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. - → Perma win ccov remote/cdp/test/browser/network/browser_getCookies.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. -
Component: Agent → CDP

I tried to run a try build to see if things have been improved meanwhile but I cannot see that we run the remote browser-chrome tests at all for CCOV builds on Windows.

Marco, can you remember why our tests for the CDP implementation have been disabled for CCOV while all other mochitests seem to still be running?

Flags: needinfo?(mcastelluccio)

Do you mean mochitest-remote? I think not running them on Windows anymore is a regression from the recent migration to 2004. https://hg.mozilla.org/mozilla-central/rev/8339eb731281 seems to have disabled a few suites, unless I'm missing something.

Flags: needinfo?(mcastelluccio) → needinfo?(jmaher)

Hm interesting. I also don't see mochitest-remote being removed from the previous config. So maybe they aren't running even for a longer time?

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+1] from comment #18)

Hm interesting. I also don't see mochitest-remote being removed from the previous config. So maybe they aren't running even for a longer time?

Before that patch, ccov was using the "standard" set of tests (windows10-2004-tests). With that patch, new sets of tests was defined for ccov specifically (windows10-64-ccov-tests and windows10-64-2004-ccov-tests), and some suites that were part of the "standard" set of tests were not included in the new "ccov-specific" sets of tests.
So I think we were running them before that patch, and we are not running them anymore since that patch.

That's it. I pushed a try build. So lets see how it works:
https://treeherder.mozilla.org/jobs?repo=try&revision=ef7467f94a4eee98ece7ec816044975accffaf25

Flags: needinfo?(jmaher)
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
status-firefox95: --- → disabled
status-firefox96: --- → disabled
status-firefox-esr91: --- → disabled

Thanks Henrik! I've moved the needinfo to Joel in bug 1727943 about the other suites.

Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d1366005eb4b
[remote] Enable mochitest-remote jobs for Windows CCOV builds. r=jmaher
https://hg.mozilla.org/integration/autoland/rev/9ecfcaf17200
[remote] Re-enable browser_getCookies.js for Windows CCOV builds. r=webdriver-reviewers,jmaher,jdescottes
Status: ASSIGNED → RESOLVED
Closed: 4 years ago → 3 years ago
status-firefox96: disabled → fixed
Keywords: leave-open, test-disabled
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: