Closed Bug 1605662 Opened 2 months ago Closed 2 months ago

CustomElementRegistry.cpp: redundant return statement at the end of a function with a void return type

Categories

(Firefox Build System :: Source Code Analysis, task)

task
Not set

Tracking

(firefox73 fixed)

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: Sylvestre, Assigned: manish.giri.me, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=C++])

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1605661 +++

Filling as a good first bug to learn workflows.

return; at the end of a void function is useless
https://searchfox.org/mozilla-central/source/dom/base/CustomElementRegistry.cpp#1023

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-control-flow.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Depends on D58225

Assignee: nobody → manish.giri.me
Status: NEW → ASSIGNED
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e8fc63a16373
Remove redundant return in void function. r=sylvestre
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.