1605687 - nsFilterInstance.cpp: Value stored to 'filterIsNoop' is never read

Status: RESOLVED FIXED

(Core :: SVG, defect, P3)

Description

[Sylvestre Ledru [:Sylvestre]]

According to:
http://sylvestre.ledru.info/reports/fx-scan-build/report-nsFilterInstance.cpp-BuildWebRenderFilters-86-1.html#EndPath

 filterIsNoop = true;

is useless because of the continue;

Maybe this line should be removed or it shows an issue with the code.

Nical, wdyt?

Comment 1

[Nicolas Silva [:nical]]

I think that we should not continue there and instead skip pushing the filter so that we benefit from the no-op cleanup at the end of the loop and avoid unnecessary color-space conversions in some cases. I'll fix that after bug 1606742 lands to avoid bitrotting Connor's patch.

Comment 2

[Nicolas Silva [:nical]]

Attachment: Bug 1605687 - Don't skip the filter noop path when running into invalid color matrices. r=cbrewster

The noop path lets us detect some unnecessary color space conversion passes.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:heycam, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8af363b4a12
Don't skip the filter noop path when running into invalid color matrices. r=cbrewster

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/c8af363b4a12