1605688 - Follow up to support for transparent manifest colors

Status: RESOLVED FIXED

(DevTools :: Application Panel, task)

Description

[Julian Descottes [:jdescottes]]

With Bug 1604917, the returned manifest color can now be transparent. The color is now returned as #RRGGBBAA instead of #RRGGBB. In Bug 1604917 we only modified one application panel test in order to support the new format.

However maybe we want to handle such colors a bit differently:

• when alpha=FF, omit the alpha value? (eg #FF0000FF would be displayed as #FF0000)
• use a checkered background behind the color so that you can visually tell the color has alpha != 1

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: image.png

Comment 2

[Tiger Oakes]

Attachment: Bug 1605688 - Strip alpha when opaque, r=jdescottes,ladybenko!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa56a4ad6f4a
Strip alpha when opaque, r=jdescottes,ladybenko

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aaefef8a5fe6
Backed out changeset fa56a4ad6f4a for devtools failures on browser_devtools_api_destroy.js. CLOSED TREE

Comment 5

[Atila Butkovits]

Backed out for devtools failures on browser_application_panel_manifest-display.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/aaefef8a5fe60b07aa3b07ad5fdda3f8620b4e83

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=fa56a4ad6f4a4854a6fdf1f56110aff7899a6c41&searchStr=dt&selectedTaskRun=Q9JgLK6pRIyiDpQNhYG5vg.0

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=308094209&repo=autoland&lineNumber=1725

''' [task 2020-06-30T23:06:30.837Z] 23:06:30 INFO - TEST-START | devtools/client/application/test/browser/browser_application_panel_manifest-display.js
[task 2020-06-30T23:06:31.783Z] 23:06:31 INFO - GECKO(1290) | -----------------------------------------------------
[task 2020-06-30T23:06:31.783Z] 23:06:31 INFO - GECKO(1290) | Suppressions used:
[task 2020-06-30T23:06:31.784Z] 23:06:31 INFO - GECKO(1290) | count bytes template
[task 2020-06-30T23:06:31.784Z] 23:06:31 INFO - GECKO(1290) | 18 568 nsComponentManagerImpl
[task 2020-06-30T23:06:31.784Z] 23:06:31 INFO - GECKO(1290) | 633 18287 libfontconfig.so
[task 2020-06-30T23:06:31.784Z] 23:06:31 INFO - GECKO(1290) | -----------------------------------------------------
[task 2020-06-30T23:06:32.591Z] 23:06:32 INFO - TEST-INFO | started process screentopng
[task 2020-06-30T23:06:32.764Z] 23:06:32 INFO - TEST-INFO | screentopng: exit 0
[task 2020-06-30T23:06:32.764Z] 23:06:32 INFO - Buffered messages logged at 23:06:30
[task 2020-06-30T23:06:32.765Z] 23:06:32 INFO - Entering test bound
[task 2020-06-30T23:06:32.765Z] 23:06:32 INFO - Test that we are displaying correctly a valid manifest
[task 2020-06-30T23:06:32.765Z] 23:06:32 INFO - Adding a new tab with URL: http://example.com/browser/devtools/client/application/test/browser/resources/manifest/load-ok.html
[task 2020-06-30T23:06:32.765Z] 23:06:32 INFO - Buffered messages logged at 23:06:31
[task 2020-06-30T23:06:32.766Z] 23:06:32 INFO - Tab added and finished loading
[task 2020-06-30T23:06:32.766Z] 23:06:32 INFO - Buffered messages logged at 23:06:32
[task 2020-06-30T23:06:32.766Z] 23:06:32 INFO - Selecting application page: manifest
[task 2020-06-30T23:06:32.766Z] 23:06:32 INFO - Waiting for the manifest to be displayed
[task 2020-06-30T23:06:32.767Z] 23:06:32 INFO - TEST-PASS | devtools/client/application/test/browser/browser_application_panel_manifest-display.js | Manifest is being displayed -
[task 2020-06-30T23:06:32.767Z] 23:06:32 INFO - TEST-PASS | devtools/client/application/test/browser/browser_application_panel_manifest-display.js | Manifest member name displays the correct value -
[task 2020-06-30T23:06:32.768Z] 23:06:32 INFO - Buffered messages finished
[task 2020-06-30T23:06:32.768Z] 23:06:32 INFO - TEST-UNEXPECTED-FAIL | devtools/client/application/test/browser/browser_application_panel_manifest-display.js | Manifest member background_color displays the correct value - Got #ff0000, expected #ff0000ff'''

Comment 6

[Tiger Oakes]

Attachment: Bug 1605688 - Strip alpha when opaque, r=jdescottes,ladybenko

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d842c1d2e906
Strip alpha when opaque, r=jdescottes

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/d842c1d2e906