1605854 - Fix some Firefox tests that use uneval/toSource

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P2)

Description

[Tom S [:evilpie]]

We want to disable uneval and Object.prototype.toSource code. To start we only plan on disabling both functions for non-chrome/content scripts, so I am only fixing those tests here.

Comment 1

[Tom S [:evilpie]]

I am making good progress getting linux64 green. Fixing js/xpconnect/tests/chrome/test_xrayToJS.xhtml is going to be a bit of work, because it uses toSource quite a bit. I am not sure yet what is causing the failure in devtools/client/dom/test/browser_dom_array.js, but it must be somewhere in the devtools code outside the test.

83 files changed, 290 insertions(+), 291 deletions(-)

Comment 2

[Tom S [:evilpie]]

Attachment: Bug 1605854 - Remove toSource from indexedDB tests r?#dom-workers-and-storage

Comment 3

[Tom S [:evilpie]]

Attachment: Bug 1605854 - Remove toSource from ServiceWorker tests. r?baku

Comment 4

[Tom S [:evilpie]]

Attachment: Bug 1605854 - Remove uneval/toSource from devtools tests. r?jlast

For test browser_net_prefs-reload.js, I am not sure about this change firstValue/currentValue seems to be different types numbers, strings, objects.
toString is maybe not the best way to compare those values.

Comment 5

[Tom S [:evilpie]]

Attachment: Bug 1605854 - Remove uneval/toSource from WebExtension tests. r?zombie

Comment 6

[Tom S [:evilpie]]

Attachment: Bug 1605854 - Fix JS test that uses toSource unconditionally r?jandem

Comment 7

[Tom S [:evilpie]]

Attachment: Bug 1605854 - Remove uneval/toSource from CORS tests. r?ckerschb

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2341c647b1a
Remove uneval/toSource from WebExtension tests. r=zombie

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e2cc12a8428
Fix JS test that uses toSource unconditionally  r=jandem

Comment 10

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/e2341c647b1a
https://hg.mozilla.org/mozilla-central/rev/6e2cc12a8428

Comment 11

[Tom S [:evilpie]]

Attachment: Bug 1605854 - Remove toSource from fission tests. r?kmag

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a1487e1518de
Remove uneval/toSource from devtools tests. r=jlast

Comment 13

[Dorel Luca [:dluca]]

Backed out changeset a1487e1518de (bug 1605854) for ESline failure in gecko/devtools/shared/transport/local-transport.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=283346358&repo=autoland&lineNumber=213

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedJob=283346358&revision=a1487e1518de2c08551f391d11708e05866edfa8

Backout:
https://hg.mozilla.org/integration/autoland/rev/84962125a899ae258104b0927890c301d2a367c4

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc16892ca752
Remove uneval/toSource from devtools tests. r=jlast

Comment 15

[Tom S [:evilpie]]

Attachment: Bug 1605854 - Remove uneval/toSource from DOM tests. r?smaug

I am not sure we should really remove toSource from Codegen.py, but I wanted to make sure to follow the test comment.

Using JSON.stringify in dom/tests/mochitest/chrome/test_clonewrapper.xhtml might not be the best solution, because
the testObject contains ImageData objects.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ceab48d53ff1
Remove toSource from indexedDB tests r=dom-workers-and-storage-reviewers,asuth

Comment 17

[Tom S [:evilpie]]

Attachment: Bug 1605854 - Fix xrayToJS test to work with conditional toSource. r?bzbarsky

Because toSource is available to chrome code, we need to adjust some parts where toSource is missing because of content contexts.
We can remove most these changes when we remove toSource everywhere.

Comment 18

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/dc16892ca752
https://hg.mozilla.org/mozilla-central/rev/ceab48d53ff1

Comment 19

[Tom S [:evilpie]]

Attachment: Bug 1605854 - Fix remaining tests using uneval/toSource r?mccr8

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cb045f399867
Remove toSource from ServiceWorker tests. r=baku

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0845f6adc577
Fix xrayToJS test to work with conditional toSource. r=bzbarsky

Comment 22

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/cb045f399867
https://hg.mozilla.org/mozilla-central/rev/0845f6adc577

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/20ee58e41fa4
Remove uneval/toSource from DOM tests. r=smaug

Comment 24

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/20ee58e41fa4

Comment 25

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea16475d26ba
Remove uneval/toSource from CORS tests. r=baku

Comment 26

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6942ba9ec310
Remove toSource from fission tests. r=kmag,botond

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a905ce83ffdb
Fix remaining tests using uneval/toSource r=mccr8,bzbarsky

Comment 28

[Cristian Brindusan [:cbrindusan]]

Backed out changeset ea16475d26ba (Bug 1605854) for mochitest failures at test_fetch_cors_sw_reroute.html.
https://hg.mozilla.org/integration/autoland/rev/16c7783f356b98d7e2e0fa5dd50176f97ff52050

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=ea16475d26ba33065de20f615ca7f9f081f4bb66&selectedJob=283837451

Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=283837451&repo=autoland&lineNumber=3788

Comment 29

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1856b9f3a157
Remove uneval/toSource from CORS tests. r=baku

Comment 30

[Tom S [:evilpie]]

I replaced a single use of toSource with JSON.stringify in test_fetch_cors_sw_reroute.html.

Comment 31

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/6942ba9ec310
https://hg.mozilla.org/mozilla-central/rev/a905ce83ffdb
https://hg.mozilla.org/mozilla-central/rev/1856b9f3a157