Fix some Firefox tests that use uneval/toSource
Categories
(Core :: JavaScript Engine, task, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox74 | --- | fixed |
People
(Reporter: evilpies, Assigned: evilpies)
References
Details
Attachments
(10 files)
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review |
We want to disable uneval and Object.prototype.toSource code. To start we only plan on disabling both functions for non-chrome/content scripts, so I am only fixing those tests here.
I am making good progress getting linux64 green. Fixing js/xpconnect/tests/chrome/test_xrayToJS.xhtml
is going to be a bit of work, because it uses toSource
quite a bit. I am not sure yet what is causing the failure in devtools/client/dom/test/browser_dom_array.js
, but it must be somewhere in the devtools code outside the test.
83 files changed, 290 insertions(+), 291 deletions(-)
Updated•5 years ago
|
For test browser_net_prefs-reload.js, I am not sure about this change firstValue/currentValue seems to be different types numbers, strings, objects.
toString is maybe not the best way to compare those values.
Comment 10•5 years ago
|
||
bugherder |
Assignee | ||
Comment 11•5 years ago
|
||
Comment 12•5 years ago
|
||
Comment 13•5 years ago
|
||
Backed out changeset a1487e1518de (bug 1605854) for ESline failure in gecko/devtools/shared/transport/local-transport.js. CLOSED TREE
Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=283346358&repo=autoland&lineNumber=213
Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedJob=283346358&revision=a1487e1518de2c08551f391d11708e05866edfa8
Backout:
https://hg.mozilla.org/integration/autoland/rev/84962125a899ae258104b0927890c301d2a367c4
Comment 14•5 years ago
|
||
Assignee | ||
Comment 15•5 years ago
|
||
I am not sure we should really remove toSource from Codegen.py, but I wanted to make sure to follow the test comment.
Using JSON.stringify in dom/tests/mochitest/chrome/test_clonewrapper.xhtml might not be the best solution, because
the testObject contains ImageData objects.
Comment 16•5 years ago
|
||
Assignee | ||
Comment 17•5 years ago
|
||
Because toSource is available to chrome code, we need to adjust some parts where toSource is missing because of content contexts.
We can remove most these changes when we remove toSource everywhere.
Comment 18•5 years ago
|
||
bugherder |
Assignee | ||
Comment 19•5 years ago
|
||
Comment 20•5 years ago
|
||
Updated•5 years ago
|
Comment 21•5 years ago
|
||
Comment 22•5 years ago
|
||
bugherder |
Comment 23•5 years ago
|
||
Comment 24•5 years ago
|
||
bugherder |
Comment 25•5 years ago
|
||
Comment 26•5 years ago
|
||
Comment 27•5 years ago
|
||
Comment 28•5 years ago
|
||
Backed out changeset ea16475d26ba (Bug 1605854) for mochitest failures at test_fetch_cors_sw_reroute.html.
https://hg.mozilla.org/integration/autoland/rev/16c7783f356b98d7e2e0fa5dd50176f97ff52050
Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=283837451&repo=autoland&lineNumber=3788
Comment 29•5 years ago
|
||
Assignee | ||
Comment 30•5 years ago
|
||
I replaced a single use of toSource
with JSON.stringify
in test_fetch_cors_sw_reroute.html.
Comment 31•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6942ba9ec310
https://hg.mozilla.org/mozilla-central/rev/a905ce83ffdb
https://hg.mozilla.org/mozilla-central/rev/1856b9f3a157
Description
•