1605867 - Improve performance when failing to launch sandboxed process.

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, enhancement, P1)

Description

[Bob Owen (:bobowen)]

While investigating another performance bug, I noticed that we pointlessly duplicate the sandbox IPC memory when we might fail to launch.

Comment 1

[Bob Owen (:bobowen)]

Attachment: Bug 1605867: Don't duplicate IPC shared memory when we might fail to launch the process correctly. r=handyman

Comment 2

[Bob Owen (:bobowen)]

Attachment: ***ESR68 patch*** Bug 1605867: Don't duplicate IPC shared memory when we might fail to launch the process correctly. r=handyman

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc6f6fedd1a1
Don't duplicate IPC shared memory when we might fail to launch the process correctly. r=handyman

Comment 4

[Bob Owen (:bobowen)]

Comment on attachment 9117818 [details]
Bug 1605867: Don't duplicate IPC shared memory when we might fail to launch the process correctly. r=handyman

Beta/Release Uplift Approval Request

• User impact if declined: Uplift requested via IRC
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just moves some code after other checks that might mean the process failed to launch correctly.
• String changes made/needed: None

Comment 5

[Bob Owen (:bobowen)]

Comment on attachment 9117819 [details]
ESR68 patch Bug 1605867: Don't duplicate IPC shared memory when we might fail to launch the process correctly. r=handyman

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Uplift requested on IRC
• User impact if declined: Uplift requested on IRC
• Fix Landed on Version: 73
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just moves some code after other checks that might mean the process failed to launch correctly.
• String or UUID changes made by this patch: None

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9117818 [details]
Bug 1605867: Don't duplicate IPC shared memory when we might fail to launch the process correctly. r=handyman

OK for uplift for beta 11.

Comment 7

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d5822b0bc63d

Comment 8

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/dc6f6fedd1a1

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 9117819 [details]
***ESR68 patch*** Bug 1605867: Don't duplicate IPC shared memory when we might fail to launch the process correctly. r=handyman

approved for 68.4

Comment 10

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/b9ced0dd1026