1605873 - networkMenu.ws.summary.tooltip.framesTranferredSize has Localization Note and entity name indicating it's a tooltip but it's a label

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P3)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Bug 1593831 added this for localization:

+# LOCALIZATION NOTE (networkMenu.ws.summary.tooltip.framesTranferredSize): A tooltip explaining
+# what the framesTranferredSize label displays
+# %1$S is the total size of the transferred data, %2$S is the size of sent data, %3$S is the size of received data.
+networkMenu.ws.summary.tooltip.framesTranferredSize=%1$S total, %2$S sent, %3$S received

Actually, it's used as a label and the entity name and Localization Note are misleading.

Steps to reproduce:

1. Open http://labs.dinahmoe.com/plink/
2. Open Netmonitor (Ctrl+Shift+E).
3. Click on 'WebSockets'.
4. Launch the game.
5. In Netmonitor, click on the line.
6. Then on the Messages tab.

Actual result:
Pretty cramped toolbar with the text shown, tooltip is networkMenu.ws.summary.tooltip.framesTotalSize

Expected result:
Like this but with correct Localization Note and entity name?

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks for the report I can see the issue.

Pretty cramped toolbar with the text shown, tooltip is networkMenu.ws.summary.tooltip.framesTotalSize

I believe you meant statusbar (not toolbar)

We should change the localization to something like as follows:

# LOCALIZATION NOTE (networkMenu.ws.summary.label.framesTranferredSize): A label showing
# summary size info related to the current list of WS messages
# %1$S is the total size of the transferred data, %2$S is the size of sent data, %3$S is the size of received data.
networkMenu.ws.summary.label.framesTranferredSize=%1$S total, %2$S sent, %3$S received

Honza

Comment 2

[Vincent Lequertier]

Hi,

can I work on this? :-)

Comment 3

[Vincent Lequertier]

Attachment: Bug 1605873 - Rename networkMenu.ws.summary.tooltip.framesTranferredSize to networkMenu.ws.summary.label.framesTranferredSize;r=Honza

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9def47165f77
Rename networkMenu.ws.summary.tooltip.framesTranferredSize to networkMenu.ws.summary.label.framesTranferredSize;r=Honza

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/9def47165f77