Closed Bug 1605876 Opened 10 months ago Closed 9 months ago

nsDocumentViewer.cpp: Remove a nested redundant #if

Categories

(Firefox Build System :: Lint and Formatting, task, P3)

task

Tracking

(firefox74 fixed)

RESOLVED FIXED
mozilla74
Tracking Status
firefox74 --- fixed

People

(Reporter: Sylvestre, Assigned: sanchit.arora.2002, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=C++])

Attachments

(1 file)

Hello, I'm starting to contribute to Mozilla. I want to work on this bug so can I please become the assignee?

I suppose in this block there are some more duplication as a part of compound conditions.
For example here
https://searchfox.org/mozilla-central/source/layout/base/nsDocumentViewer.cpp#3723

Am I right?

Flags: needinfo?(sledru)

(In reply to sanchit.arora.2002 from comment #1)

Hello, I'm starting to contribute to Mozilla. I want to work on this bug so can I please become the assignee?

Yeah, the block begins here it seems:
https://searchfox.org/mozilla-central/source/layout/base/nsDocumentViewer.cpp#3416

I will assign it to the first person who proposes a patch

Flags: needinfo?(sledru)

sanchit.arora.2000, I don't want to steal your opportunity, I will proposes a patch in two days if you don't do it before.
Is it fair enough?

(In reply to Aleksei Kharinskiy from comment #5)

sanchit.arora.2000, I don't want to steal your opportunity, I will proposes a patch in two days if you don't do it before.
Is it fair enough?

Thanks a lot for letting me take this opportunity.

I have plenty of bugs like this.
Feel free to send me an email to request for me

(In reply to Sylvestre Ledru [:Sylvestre] from comment #7)

I have plenty of bugs like this.
Feel free to send me an email to request for me

I submitted the patch for this bug, could you please let me know the next step?

Flags: needinfo?(sledru)
Assignee: nobody → sanchit.arora.2002
Status: NEW → ASSIGNED

Landed, sorry for the latency!

Flags: needinfo?(sledru)
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/87581ad586de
Removed redundant #if(s). r=smaug
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.