1605876 - nsDocumentViewer.cpp: Remove a nested redundant #if

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task, P3)

Description

[Sylvestre Ledru [:Sylvestre]]

Filling as a good first bug to learn workflows.

NS_PRINTING is checked twice and we are in the same block
https://searchfox.org/mozilla-central/source/layout/base/nsDocumentViewer.cpp#3710

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-preprocessor.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Comment 1

[sanchit.arora.2002]

Hello, I'm starting to contribute to Mozilla. I want to work on this bug so can I please become the assignee?

Comment 2

[Aleksei Kharinskiy]

I suppose in this block there are some more duplication as a part of compound conditions.
For example here
https://searchfox.org/mozilla-central/source/layout/base/nsDocumentViewer.cpp#3723

Am I right?

Comment 3

[sanchit.arora.2002]

(In reply to sanchit.arora.2002 from comment #1)

Hello, I'm starting to contribute to Mozilla. I want to work on this bug so can I please become the assignee?

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Yeah, the block begins here it seems:
https://searchfox.org/mozilla-central/source/layout/base/nsDocumentViewer.cpp#3416

I will assign it to the first person who proposes a patch

Comment 5

[Aleksei Kharinskiy]

sanchit.arora.2000, I don't want to steal your opportunity, I will proposes a patch in two days if you don't do it before.
Is it fair enough?

Comment 6

[sanchit.arora.2002]

(In reply to Aleksei Kharinskiy from comment #5)

sanchit.arora.2000, I don't want to steal your opportunity, I will proposes a patch in two days if you don't do it before.
Is it fair enough?

Thanks a lot for letting me take this opportunity.

Comment 7

[Sylvestre Ledru [:Sylvestre]]

I have plenty of bugs like this.
Feel free to send me an email to request for me

Comment 8

[sanchit.arora.2002]

(In reply to Sylvestre Ledru [:Sylvestre] from comment #7)

I have plenty of bugs like this.
Feel free to send me an email to request for me

I submitted the patch for this bug, could you please let me know the next step?

Comment 9

[sanchit.arora.2002]

Attachment: Bug 1605876 - Removed redundant #if(s). r=smaug

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Landed, sorry for the latency!

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/87581ad586de
Removed redundant #if(s). r=smaug

Comment 12

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/87581ad586de