Closed Bug 1605878 Opened 3 months ago Closed 3 months ago

TypeInference.cpp: Remove a nested redundant #if

Categories

(Firefox Build System :: Lint and Formatting, task, P3, minor)

task

Tracking

(firefox73 fixed)

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: Sylvestre, Assigned: fella, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=C++])

Attachments

(1 file)

Filling as a good first bug to learn workflows.

DEBUG is checked twice and we are in the same block
https://searchfox.org/mozilla-central/source/js/src/vm/TypeInference.cpp#244

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-preprocessor.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Assignee: nobody → fella
Status: NEW → ASSIGNED
Pushed by iireland@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/32ee210f9ce1
Remove a nested redundant #if. r=iain
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.