1605879 - ./mach static-analysis is failing when too many files

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

Example

$ ./mach static-analysis check --checks="-*,readability-redundant-smartptr-get" dom/

returns:

Error running mach:

    ['static-analysis', 'check', '--checks=-*,readability-redundant-smartptr-get', 'dom']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke |./mach busted| to check if this issue is already on file. If it
isn't, please use |./mach busted file| to report it. If |./mach busted| is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

OSError: [Errno 7] Argument list too long

  File "/home/sylvestre/dev/mozilla/mozilla-central.hg/python/mozbuild/mozbuild/code-analysis/mach_commands.py", line 285, in check
    line_handler=output_manager.on_line, cwd=cwd)
  File "/home/sylvestre/dev/mozilla/mozilla-central.hg/python/mach/mach/mixin/process.py", line 124, in run_process
    p.run()
  File "/home/sylvestre/dev/mozilla/mozilla-central.hg/testing/mozbase/mozprocess/mozprocess/processhandler.py", line 811, in run
    self.proc = self.Process([self.cmd] + self.args, **args)
  File "/home/sylvestre/dev/mozilla/mozilla-central.hg/testing/mozbase/mozprocess/mozprocess/processhandler.py", line 123, in __init__
    universal_newlines, startupinfo, creationflags)
  File "/usr/lib/python2.7/subprocess.py", line 394, in __init__
    errread, errwrite)
  File "/usr/lib/python2.7/subprocess.py", line 1047, in _execute_child
    raise child_exception

We should probably split the execution

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Andi, rings a bell?

Comment 2

[Andi [:andi]]

This is a side effect once we added https://searchfox.org/mozilla-central/source/python/mozbuild/mozbuild/code-analysis/mach_commands.py#2022 since what we do now is we build a list with all of the files from the path that we specify and past it to run-clang-tidy.py. I propose to keep the list but do something similar to what we do here: https://searchfox.org/mozilla-central/source/python/mozbuild/mozbuild/code-analysis/mach_commands.py#2179. We will run run-clang-tidy.py on sized chunks.

Comment 3

[Andi [:andi]]

Attachment: Bug 1605879 - for `clang-tidy` based static-analysis pass the files for analysis in chuncks. r=sylvestre

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:Sylvestre, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca5a75b0c9df
for `clang-tidy` based static-analysis pass the files for analysis in chuncks. r=sylvestre

Comment 6

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/ca5a75b0c9df

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Thanks andi!