Closed Bug 1605918 Opened 4 years ago Closed 4 years ago

Get rid of `synthesizeDragStart()` in EventUtils.js

Categories

(Core :: DOM: UI Events & Focus Handling, task)

task
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

Attachments

(1 file)

All usage of synthesizeDragStart() is, starting drag, cancel dragstart, and finally compares dataTransfer items and given expected data. So, we can make the users use synthesizePlainDragAndDrop() instead. It's better API because it computes position of mouse operations at runtime and checks whether the drag start was succeeded with optional logging feature (i.e., it's easier to debug of intermittent failures).

All usage of synthesizeDragStart() is, starting drag, cancel dragstart,
and finally compares dataTransfer items and given expected data. So,
we can make the users use synthesizePlainDragAndDrop() instead. It's
better API because it computes position of mouse operations at runtime and
checks whether the drag start was succeeded with optional logging feature
(i.e., it's easier to debug of intermittent failures).

This patch creates synthesizePlainDragAndCancel() for convenience. It
handles dragstart instead of the callers.

Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/ceba96868b5f
Get rid of synthesizeDragStart() in EventUtils.js r=smaug
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
Depends on: 1606216
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: