1605936 - [Megabar] Horizontal Separator is not aligned with the Toolbar border when the Megabar is in expanded mode after text input

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Mehmet]

Attachment: Actual_vs_Expected_vs_Spec.png

Nighly 73.0a1 (2019-12-24) (64-Bit)
macOS (probably OS=All Desktop)

1.) Type something into the Address Bar
2.) Take a look at the horizontal separator between the Address Bar and the results.

Actual: There is 2px too much padding between the Address Bar Input Text and the Separator when the Megabar is in expanded mode with results, so that the horizontal separator is not aligned with the Toolbar border.

Expected: Reduce the padding between the Address Bar Input Text and the Separator when the Megabar is in expanded mode with results, so that the horizontal separator is nicely aligned with the Toolbar border. That would match the spec at https://mozilla.invisionapp.com/share/MCUOETHBR4F#/screens/391775121_Specification

Screenshots are attached.

Thanks.

Comment 1

[Harry Twyford]

Attachment: Bug 1605936 - Align horizontal seperator with toolbar border. r?dao

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a72032848b0
Align horizontal seperator with toolbar border. r=dao

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/0a72032848b0

Comment 4

[Mehmet]

Very nice. Thanks for the fix :)

Comment 5

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Reproduced the issue using firefox 73.0a1 (20191224212327) on Windows 10x64.
The issue is verified using Firefox 74.0 (20200309095159) on Windows 10x64, macOS 10.15 and Ubuntu 18.04.