1605991 - Crashes on some sites with a web manifest

Status: RESOLVED FIXED

(GeckoView :: General, defect, P1)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

We're throwing "Invalid color format". Introduced by Bug 1604917.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1605991 - Avoid coercing null manifest colors into "null"

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9fd25d45d388
Avoid coercing null manifest colors into "null" r=geckoview-reviewers,rbarker

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/9fd25d45d388

Comment 5

[Andreea Pavel [:apavel]]

Hi James, bug 1568050 has been closed as a duplicate of this one and there is a recent failure in today's beta simulations.

Treeherder link: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=ec95a9b6fb3da934dca8dacc4b0f419658e09c8e&selectedJob=282746132

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=282746132&repo=try&lineNumber=1533

Does this fix need to be uplifted or should I file a different bug for it?

Comment 6

[Razvan Maries]

Same failure could be found on autoland: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=282746884&repo=autoland&lineNumber=1526

Comment 7

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to Andreea Pavel [:apavel] from comment #5)

Hi James, bug 1568050 has been closed as a duplicate of this one and there is a recent failure in today's beta simulations.

Treeherder link: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=ec95a9b6fb3da934dca8dacc4b0f419658e09c8e&selectedJob=282746132

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=282746132&repo=try&lineNumber=1533

Does this fix need to be uplifted or should I file a different bug for it?

This doesn't have the same cause AFAICT, so needs a new bug.

Comment 8

[Andreea Pavel [:apavel]]

Thank you, filed bug 1606122.

Comment 9

[Intermittent Failures Robot]

4 failures in 1365 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 3
• autoland: 1

Platform breakdown:

• android-hw-g5-7-0-arm7-api-16: 3
• android-hw-p2-8-0-android-aarch64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1605991&startday=2019-12-23&endday=2019-12-29&tree=all