Closed Bug 1606066 Opened 7 months ago Closed 6 months ago

Remove some address book interfaces

Categories

(MailNews Core :: Address Book, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 73.0

People

(Reporter: darktrojan, Assigned: darktrojan)

References

Details

Attachments

(3 files)

I want to reduce complexity in the address book code by removing some superfluous interfaces:

  • nsIAbDirectorySearch isn't used for anything. I'll remove it.
  • nsIAbCollection isn't directly used for anything, and it has only one subinterface, (nsIAbDirectory). I'll combine them.
  • nsIAbItem is inexplicably inherited by both nsIAbCard and nsIAbDirectory despite their lack of similarities. I'll move the relevant pieces into the inheriting interfaces.

There may well be others, but this is a good start.

Attachment #9117858 - Flags: review?(mkmelin+mozilla)
Attachment #9117859 - Flags: review?(mkmelin+mozilla)
Attachment #9117860 - Flags: review?(mkmelin+mozilla)
Attachment #9117858 - Flags: review?(mkmelin+mozilla) → review+
Attachment #9117859 - Flags: review?(mkmelin+mozilla) → review+
Comment on attachment 9117860 [details] [diff] [review]
1606066-nsiabitem.diff

Review of attachment 9117860 [details] [diff] [review]:
-----------------------------------------------------------------

All looks good, thx! r=mkmelin
Attachment #9117860 - Flags: review?(mkmelin+mozilla) → review+
Blocks: 1606284
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 73.0
You need to log in before you can comment on or make changes to this bug.