1606066 - Remove some address book interfaces

Status: RESOLVED FIXED

(MailNews Core :: Address Book, task)

Description

[Geoff Lankow (:darktrojan) [PTO, back 28/4]]

I want to reduce complexity in the address book code by removing some superfluous interfaces:

• nsIAbDirectorySearch isn't used for anything. I'll remove it.
• nsIAbCollection isn't directly used for anything, and it has only one subinterface, (nsIAbDirectory). I'll combine them.
• nsIAbItem is inexplicably inherited by both nsIAbCard and nsIAbDirectory despite their lack of similarities. I'll move the relevant pieces into the inheriting interfaces.

There may well be others, but this is a good start.

Comment 1

[Geoff Lankow (:darktrojan) [PTO, back 28/4]]

Attachment: 1606066-nsiabdirectorysearch.diff

Comment 2

[Geoff Lankow (:darktrojan) [PTO, back 28/4]]

Attachment: 1606066-nsiabcollection.diff

Comment 3

[Geoff Lankow (:darktrojan) [PTO, back 28/4]]

Attachment: 1606066-nsiabitem.diff

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9117860 [details] [diff] [review]
1606066-nsiabitem.diff

Review of attachment 9117860 [details] [diff] [review]:
-----------------------------------------------------------------

All looks good, thx! r=mkmelin

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a6f54c89daf7
Remove nsIAbDirectorySearch; r=mkmelin
https://hg.mozilla.org/comm-central/rev/12617633b4ff
Remove nsIAbCollection; r=mkmelin
https://hg.mozilla.org/comm-central/rev/81d8400783ab
Remove nsIAbItem; r=mkmelin