Closed Bug 1606074 Opened 1 year ago Closed 1 year ago

Simplify BytecodeAnalysis and BytecodeParser a bit

Categories

(Core :: JavaScript Engine, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(3 files)

After the recent bytecode changes for loops, bytecode can now be parsed in order so we can remove some complexity for backedges.

Depends on: 1606080
Priority: -- → P2

Now that all loops use the same simple structure, the backedge is only reachable
via the loophead.

This removes the currentOffset in/out param from addJump and simplifies the
iteration code a bit.

Depends on D58423

Just a drive-by fix, unrelated to the previous changes.

The BytecodeParser code already does the right thing.

Depends on D58424

Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b845a7fc7f9f
part 1 - Simplify BytecodeAnalysis to always analyze in order. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/07cc46828c95
part 2 - Simplify BytecodeParser to always analyze in order. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/a748a5149bda
part 3 - Fix try note check in BytecodeAnalysis::init. r=tcampbell
You need to log in before you can comment on or make changes to this bug.