Closed
Bug 1606074
Opened 4 years ago
Closed 4 years ago
Simplify BytecodeAnalysis and BytecodeParser a bit
Categories
(Core :: JavaScript Engine, task, P2)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla73
| Tracking | Status | |
|---|---|---|
| firefox73 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(3 files)
After the recent bytecode changes for loops, bytecode can now be parsed in order so we can remove some complexity for backedges.
|
||
Updated•4 years ago
|
Priority: -- → P2
|
Assignee | |
Comment 1•4 years ago
|
||
Now that all loops use the same simple structure, the backedge is only reachable
via the loophead.
|
|
Assignee | |
Comment 2•4 years ago
|
||
This removes the currentOffset in/out param from addJump and simplifies the
iteration code a bit.
Depends on D58423
|
|
Assignee | |
Comment 3•4 years ago
|
||
Just a drive-by fix, unrelated to the previous changes.
The BytecodeParser code already does the right thing.
Depends on D58424
Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b845a7fc7f9f part 1 - Simplify BytecodeAnalysis to always analyze in order. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/07cc46828c95 part 2 - Simplify BytecodeParser to always analyze in order. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/a748a5149bda part 3 - Fix try note check in BytecodeAnalysis::init. r=tcampbell
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b845a7fc7f9f
https://hg.mozilla.org/mozilla-central/rev/07cc46828c95
https://hg.mozilla.org/mozilla-central/rev/a748a5149bda
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox73:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in
before you can comment on or make changes to this bug.
Description
•