1606187 - Remove usage of nsAutoPtr in nsClassHashtable

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Eric Rahm [:erahm]]

After bug 1241518, nsClassHashtable will be the last remaining usage of nsAutoPtr in xpcom/. Ideally we'll convert it over to using UniquePtr.

There are a couple of issues beyond just conversion:

1. nsBaseHashtable expects implicit conversion from UserDataType to DataType which UniquePtr intentionally does not support. For example the Iterator class expects this.
2. nsBaseHashtable expects implicit assignment from UserDataType to DataType which UniquePtr intentionally does not support. For example nsBaseHashtable::Put currently uses this.
3. nsBaseHashtable::Remove has an optional out param that hands out a moved DataType, all callers that use that need to be updated to use UniquePtr instead for the out param

Comment 1

[Eric Rahm [:erahm]]

Attachment: Bug 1606187 - Part 1: Add a DataType conversion helper to nsBaseHashtable

Comment 2

[Eric Rahm [:erahm]]

Attachment: Bug 1606187 - Part 2a: Switch nsClassHashtable over to UniquePtr

Comment 3

[Eric Rahm [:erahm]]

Attachment: Bug 1606187 - Part 2b: Update users of nsClassHashtable to handle UniquePtr differences

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/910c51f0c374
Part 1: Add a DataType conversion helper to nsBaseHashtable r=froydnj,KrisWright
https://hg.mozilla.org/integration/autoland/rev/e5a8dac17bba
Part 2a: Switch nsClassHashtable over to UniquePtr r=KrisWright,froydnj
https://hg.mozilla.org/integration/autoland/rev/416ad9bef391
Part 2b: Update users of nsClassHashtable to handle UniquePtr differences r=KrisWright,froydnj

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/910c51f0c374
https://hg.mozilla.org/mozilla-central/rev/e5a8dac17bba
https://hg.mozilla.org/mozilla-central/rev/416ad9bef391