160623 - venkman 's help cannt display Chinese after localization.

Status: RESOLVED FIXED

(Other Applications Graveyard :: Venkman JS Debugger, defect)

Description

[shaohua wen]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; zh-CN; rv:1.1b) Gecko/20020731
BuildID:    2002073118

I am a mozilla Simplified Chinese translator,
in Chinese localization build of mozilla,when call the x-jsd:help
,the help displayed in the mozilla navigator window,but the localized 
string did not displayed corrrectly,and the layout was broken!
I found that the problem was caused by the venkman.properties file,
in this file ,localized string are presented like
:\u6D4B\u8BD5\u53C2\u6570\u5206 (unicode)
but in the other dtd files, localized string are like 
<!ENTITY venkmanCmd.label "JavaScript µ÷ÊÔÆ÷">.
Maybe venkman cannt handle unicode corroctly or some bug else?


Reproducible: Always
Steps to Reproduce:
1.install  Simplified Chinese lang pack for 1.1beta 
2.open javascript debugger
3.visit x-jsd:help


Actual Results:  unknown symbols

Expected Results:  localized Chinese symbols

Comment 1

[shaohua wen]

Attachment: the screenshot 1,shows the x-jsd help .

Comment 2

[shaohua wen]

Attachment: the help's wrong layout screenshot

Comment 3

[shaohua wen]

This also happens on mozilla 1.1beta

Comment 4

[Robert Ginda]

Can you get this to happen in a small file, say x-jsd:help?search=float, then do
a File->Save Page As..., and attach the results here.

I have a feeling this is due to the fact that venkman munges certain text, like
<this> and |this|.

Comment 5

[shaohua wen]

Attachment: html page saved from the sample of x-jsd:help?search=float

extract the zip file and there is the html file.

Comment 6

[Robert Ginda]

Attachment: proposed patch

Venkman searches out patterns like <this>, |this|, and *this*, inorder to
translate them to "&lt;this&gt;", "<tt>this</tt>", and "<b>this</b>" for HTML
output.  When encodings use <, >, or | characters for other reasons, things get
understandably confused.

This patch attempts to fix the problem by searching for the special characters
ONLY if they follow (or proceed) a low-byte ascii character.

I'm about to post this as 0.9.30 to <http://www.hacksrus.com/~ginda/venkman/>.

Comment 7

[Robert Ginda]

Comment on attachment 93693 [details] [diff] [review]
proposed patch

This isn't going to work, I'm going to have to look into this a bit more :(

Comment 8

[chado]

This is same on Japanese localization.
Now, I have temporary workaround, converting localized strings to NCR 
in function svc_help in the venkman-jsdurl.js.

Here is modified venkman-jsdurl.js for venkman 0.9.24 comes with Mozilla 1.1 beta.
http://bugzilla.mozilla.gr.jp/showattachment.cgi?attach_id=1009
(You can reach where modified by finding strings "chado")

I hope this makes any little help, although I don't know if it works in Chinese. 

Comment 9

[shaohua wen]

I have tested this file in my mozilla 1.1beta,
Yes, it really works.

Comment 10

[Robert Ginda]

That's a pretty neat idea, but I'd prefer to use mozilla's charset encoders if
possible.  I just posted version 0.9.33 to
<http://www.hacksrus.com/~ginda/venkman/>, which adds "msg.report.charset" to
the venkman.properties file.  If you install this version and add
"msg.report.charset = utf-8" to your localized venkman.properties file,
everything *should* work.

Venkman will encode the unicode strings from venkman.properties into the
selected character set before writing generating the help text.

Please try this and let me know if it works, I'd like to fix this bug for
mozilla1.1 :)

Comment 11

[shaohua wen]

tested,it works ,but still some small problem.

Comment 12

[shaohua wen]

Attachment: some strings are displayed as %E5%85%B3%E4%BA%8EMozilla%20%28A%29

the screen shot of the wrong displayed strings

Comment 13

[shaohua wen]

Attachment: sample html file saved from x-jsd:help

sample html file saved from x-jsd:help

Comment 14

[chado]

Using venkman 0.9.33, ui-lavel fields in x-jsd:help seems to have problem, 
even before localizing (means in en-US). Special charcters looks escaped.

I think this line, in the function svc_help in the venkman-jsdurl.js, is 
causing shaohua's *small* problem:
> "\\$ui-label": escape(command.labelstr, MSG_REPORT_CHARSET),
should may be :
> "\\$ui-label": fromUnicode(command.labelstr, MSG_REPORT_CHARSET),

Comment 15

[Robert Ginda]

chado: yes, exactly the problem.  I'll fix it before I check anything in.

Comment 16

[chado]

I've tried revision vnk0.9.34 with Japanese localization. 
Things are now looking good. We're happy to see quick fixing.

I hope this fix get going into Mozilla 1.1 final release. 

Comment 17

[Robert Ginda]

Already checked in :)