1606257 - [wpt-sync] Sync PR 20934 - Add tests for cookies' `Domain` attribute.

Status: RESOLVED FIXED

(Core :: Networking: Cookies, task, P5)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 20934 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20934
Details from upstream follow.

Mike West <[e-mail]> wrote:

Add tests for cookies' Domain attribute.

The current WPT suite for cookies' domain attribute is quite broken; we
did a bad job porting it. This patch adds tests for the specific case
called out in https://github.com/httpwg/http-extensions/issues/238,
and described in https://tools.ietf.org/html/rfc6265#section-5.2.3.

Change-Id: Ib8614d5834e028cfc093594b22bc7c8cb4f086a2
Reviewed-on: https://chromium-review.googlesource.com/1983228
WPT-Export-Revision: 8faebf00ca7e6e44e52b69228994790dc2110d5f

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=addf6862a16e9cc0c5daf4e99b3f90b8d1498efb

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 3 subtests

Status Summary

Firefox

OK : 4
PASS: 11
FAIL: 1

Chrome

OK : 4
PASS: 11
FAIL: 1

Safari

OK : 4
PASS: 11
FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/cookies/domain/domain-attribute-missing.sub.html
No domain attribute => not sent with subdomain requests.: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 43 tests

Status Summary

Firefox

OK : 4
PASS: 11[['GitHub']] 50[[u'Gecko-android-em-7.0-x86_64-debug-geckoview', u'Gecko-android-em-7.0-x86_64-opt-geckoview', u'Gecko-linux64-asan-opt', u'Gecko-linux64-debug', u'Gecko-linux64-opt', u'Gecko-linux64-qr-debug', u'Gecko-linux64-qr-opt', u'Gecko-windows10-64-debug', u'Gecko-windows10-64-opt', u'Gecko-windows10-64-qr-debug', u'Gecko-windows10-64-qr-opt', u'Gecko-windows7-32-debug', u'Gecko-windows7-32-opt']]
FAIL: 1

Chrome

OK : 4
PASS: 11
FAIL: 1

Safari

OK : 4
PASS: 11
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/cookies/domain/domain-attribute-missing.sub.html
No domain attribute => not sent with subdomain requests.: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed3641e75b91
[wpt PR 20934] - Add tests for cookies' `Domain` attribute., a=testonly
https://hg.mozilla.org/integration/autoland/rev/cb9cf5c78f73
[wpt PR 20934] - Update wpt metadata, a=testonly

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/ed3641e75b91
https://hg.mozilla.org/mozilla-central/rev/cb9cf5c78f73