1606285 - Convert LDAP offline replication to use SQLite instead of Mork

Status: RESOLVED FIXED

(MailNews Core :: Address Book, task)

Description

[Geoff Lankow (:darktrojan)]

This changes for this bug got tangled up in the work for bug 1606284. I could untangle them but it's easier just to land both together.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1606285-ldap-replication-1.diff

This converts the code to use SQLite instead of Mork and does a migration for existing databases. It's not a perfect replacement, e.g. replacing the active database with the backup one if the user aborts replication might fail. There's no easy way around this (yet) – closing the database is an async operation and it can't be made to happen from C++ because we don't have the interfaces for that.

I think in the longer term we should totally redo LDAP replication – it's a mess IMO.

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9118018 [details] [diff] [review]
1606285-ldap-replication-1.diff

Review of attachment 9118018 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin

::: mailnews/addrbook/src/nsAbLDAPReplicationData.cpp
@@ +127,5 @@
>      if (NS_SUCCEEDED(rv)) mState = kIdle;
>    }
>  
>    if (mReplicationDB && mDBOpen) {
>      // force close since we need to delete the file.

this comment seems in need of adjustment

::: mailnews/addrbook/test/unit/test_migration8.js
@@ +1,5 @@
> +/* This Source Code Form is subject to the terms of the Mozilla Public
> + * License, v. 2.0. If a copy of the MPL was not distributed with this
> + * file, you can obtain one at http://mozilla.org/MPL/2.0/. */
> +
> +/*

/** style please

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4ac150bcbb59
Convert LDAP offline replication to use SQLite instead of Mork; r=mkmelin