160643 - case sensitive issue of the special 'IMAP Server Directory' setting - 'INBOX'

Status: NEW

(MailNews Core :: Networking: IMAP, defect)

Description

[Henry Jia]

When you set the 'IMAP Server Directory' of IMAP servers that have the 'INBOX.'
namespace to case insensitive 'INBOX', such as 'inbox', 'Inbox', etc, you'll see
that the folders are shown both under 'INBOX' folder and parallelly with 'INBOX'
folder.

See comment in bug 27002
(http://bugzilla.mozilla.org/show_bug.cgi?id=27002#c109)

Steps to reproduce:
1. set an account in which the IMAP server has an 'INBOX.' namespace
2. set the 'IMAP Server Directory' advanced setting to 'inbox'
3. refresh the folders showing

Expect:
the folders originally under 'INBOX' should only show parallelly with 'INBOX'

Result:
the folders show both under 'INBOX' and parallelly with 'INBOX', so confusing.

Add bienvenu & Michael Klose to CC list.

Comment 1

[Henry Jia]

Attachment: snapshot of this issue

Comment 2

[Henry Jia]

Taking. :-)

Add Seth to the CC list.

Comment 3

[Henry Jia]

Attachment: patch for review

Make the parser nsImapUrl::AllocateCanonicalPath case insensitive for the
specific 'INBOX'.

Comment 4

[Henry Jia]

Attachment: result with the patch

Comment 5

[Henry Jia]

Add cavin & navin to the CC list.

Pls r=. Thx.

Comment 6

[David :Bienvenu]

If I understand this patch correctly, you're just trying to extend the logic of
checking if the currentPath starts with the onlineDir to be case-insensitive if
the  onlineDir is INBOX. I don't think that should take an extra 30 lines of
code. I'll try to come up with a more succinct approach.

Comment 7

[Henry Jia]

Attachment: patch for review

A clearer patch for review.

Comment 8

[Henry Jia]

Comment on attachment 96667 [details] [diff] [review]
patch for review

1/3 lines are related to comments & ASSERTION.

Comment 9

[philip zhao]

How about set server directory directly to "INBOX" by ignoring case in 
nsImapIncomingServer::SetServerDirectory if we really need to fix this bug ?

Comment 10

[Rafael Ebron (:rebron)]

Mail Triage: nsbeta1-

Comment 11

[jm]

We have an issue where TB no longer finds the subscribed folder if capitalization of "INBOX" changes. As far as I understood RFC 3501, INBOX and iNbOx and whatever combination is completely valid since Inbox itself is case-insensitive.

Example:

TB is subscribed to INBOX/schaiss2:

# curl imap://mail01/ -u [e-mail]: -X 'LIST "" "*"'
* LIST () "/" "INBOX"
* LIST (\Trash) "/" "Deleted Items"
* LIST (\Drafts) "/" "Drafts"
* LIST (\Sent) "/" "Sent Items"
* LIST () "/" "INBOX/schaiss2"
# curl imap://mail01/ -u [e-mail]: -X 'LSUB "" "*"'
* LSUB () "/" "Drafts"
* LSUB () "/" "Sent Items"
* LSUB () "/" "Deleted Items"
* LSUB () "/" "INBOX"
* LSUB () "/" "INBOX/schaiss2"

Now there is a change:

# curl imap://mail01/ -u [e-mail]: -X 'LIST "" "*"'
* LIST () "/" "INBOX"
* LIST (\Trash) "/" "Deleted Items"
* LIST (\Drafts) "/" "Drafts"
* LIST (\Sent) "/" "Sent Items"
* LIST () "/" "INBOX/schaiss2"
# curl imap://mail01/ -u [e-mail]: -X 'LSUB "" "*"'
* LSUB () "/" "Drafts"
* LSUB () "/" "Sent Items"
* LSUB () "/" "Deleted Items"
* LSUB () "/" "INBOX"
* LSUB () "/" "Inbox/schaiss2"

TB nows greys out that folder, whereas it should not.

Comment 12

[yr]

Hello this also causes us IMAP synchronisation issues when users rename folders. So we as helpdesk often have to step in which is annoying, just because the RFC is not followed by Thunderbird as it is by mailserver software. Please fix this