1606452 - Error calling ./mach clang-format: You're using an old version of clang-format binary

Status: RESOLVED FIXED

(Firefox Build System :: Bootstrap Configuration, defect)

Description

[Andreas Tolfsen ❲:ato❳]

I don’t know if this is a regression or not because I rarely write any C++, but I’m unable to run ./mach clang-format. It recommends to run ./mach bootstrap but complains with the same error after I do that:

% ./mach clang-format 
 0:00.59 You're using an old version of clang-format binary. Please update to a more recent one by running: './mach bootstrap'
% ./mach bootstrap

Note on Artifact Mode:

Artifact builds download prebuilt C++ components rather than building
them locally. Artifact builds are faster!

Artifact builds are recommended for people working on Firefox or
Firefox for Android frontends, or the GeckoView Java API. They are unsuitable
for those working on C++ code. For more information see:
https://developer.mozilla.org/en-US/docs/Artifact_builds.

Please choose the version of Firefox you want to build:
  1. Firefox for Desktop Artifact Mode
  2. Firefox for Desktop
  3. GeckoView/Firefox for Android Artifact Mode
  4. GeckoView/Firefox for Android
Your choice: 2
Executing as root: sudo apt-get install autoconf2.13 build-essential nodejs python-dev python-pip python-setuptools unzip uuid zip
[sudo] password for ato: 
Reading package lists... Done
Building dependency tree       
Reading state information... Done
autoconf2.13 is already the newest version (2.13-68).
python-pip is already the newest version (18.1-5).
zip is already the newest version (3.0-11+b1).
build-essential is already the newest version (12.8).
nodejs is already the newest version (10.17.0~dfsg-2).
python-dev is already the newest version (2.7.17-2).
python-setuptools is already the newest version (41.4.0-1).
unzip is already the newest version (6.0-25).
uuid is already the newest version (1.6.2-1.5+b8).
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
Executing as root: sudo apt-get install libasound2-dev libcurl4-openssl-dev libdbus-1-dev libdbus-glib-1-dev libgtk-3-dev libgtk2.0-dev libpulse-dev libx11-xcb-dev libxt-dev python-dbus xvfb yasm
Reading package lists... Done
Building dependency tree       
Reading state information... Done
libdbus-glib-1-dev is already the newest version (0.110-4).
libxt-dev is already the newest version (1:1.1.5-1+b3).
yasm is already the newest version (1.3.0-2+b1).
libasound2-dev is already the newest version (1.1.9-1).
libcurl4-openssl-dev is already the newest version (7.67.0-2).
libdbus-1-dev is already the newest version (1.12.16-2).
libgtk-3-dev is already the newest version (3.24.13-1).
libgtk2.0-dev is already the newest version (2.24.32-4).
libpulse-dev is already the newest version (13.0-3).
libx11-xcb-dev is already the newest version (2:1.6.8-1).
python-dbus is already the newest version (1.2.14-1).
xvfb is already the newest version (2:1.20.6-1).
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
Your version of Mercurial (5.2) is sufficiently modern.
Your version of Python (2.7.17) is new enough.
Your version of Rust (1.39.0) is new enough.
Rust supports aarch64-linux-android, aarch64-pc-windows-msvc, i686-linux-android, i686-unknown-linux-musl, thumbv7neon-linux-androideabi, x86_64-linux-android, x86_64-unknown-linux-gnu, x86_64-unknown-linux-musl targets.

Mozilla recommends using git-cinnabar to work with mozilla-central (or
mozilla-unified).

Would you like to run a few configuration steps to ensure Git is
optimally configured? (Yn): n
 0:03.25 Setting up artifact node.tar.xz
 0:03.25 Using artifact from local cache: /home/ato/.mozbuild/toolchains/1b3c5557d0cff91b-node.tar.xz
 0:03.29 rm tree: /home/ato/.mozbuild/node
 0:03.38 untarring "/home/ato/.mozbuild/node.tar.xz"
 0:03.00 Setting up artifact clang.tar.xz
 0:03.00 Using artifact from local cache: /home/ato/.mozbuild/toolchains/bcc5b40b3c2d2f63-clang.tar.xz
 0:03.47 rm tree: /home/ato/.mozbuild/clang
 0:03.54 untarring "/home/ato/.mozbuild/clang.tar.xz"
A 0:02.87 Setting up artifact cbindgen.tar.xz
 0:02.87 Using artifact from local cache: /home/ato/.mozbuild/toolchains/0a96d9346ac57fbd-cbindgen.tar.xz
 0:02.88 rm tree: /home/ato/.mozbuild/cbindgen
 0:02.88 untarring "/home/ato/.mozbuild/cbindgen.tar.xz"
 0:02.82 Setting up artifact clang-tidy.tar.xz
 0:02.82 Using artifact from local cache: /home/ato/.mozbuild/toolchains/a45c72fbbba6fb76-clang-tidy.tar.xz
 0:02.98 rm tree: /home/ato/.mozbuild/clang-tools/clang-tidy
 0:03.04 untarring "/home/ato/.mozbuild/clang-tools/clang-tidy.tar.xz"
 0:03.09 Setting up artifact nasm.tar.bz2
 0:03.09 Using artifact from local cache: /home/ato/.mozbuild/toolchains/f7d81fd00928342a-nasm.tar.bz2
 0:03.12 rm tree: /home/ato/.mozbuild/nasm
 0:03.12 untarring "/home/ato/.mozbuild/nasm.tar.bz2"
 0:02.81 Setting up artifact sccache.tar.xz
 0:02.81 Using artifact from local cache: /home/ato/.mozbuild/toolchains/0f1ff5c25c52aed8-sccache.tar.xz
 0:02.84 rm tree: /home/ato/.mozbuild/sccache
 0:02.84 untarring "/home/ato/.mozbuild/sccache.tar.xz"
 0:02.88 Setting up artifact lucetc.tar.xz
 0:02.88 Using artifact from local cache: /home/ato/.mozbuild/toolchains/22e34732aeb87b91-lucetc.tar.xz
 0:02.89 rm tree: /home/ato/.mozbuild/lucetc
 0:02.89 untarring "/home/ato/.mozbuild/lucetc.tar.xz"
 0:03.00 Setting up artifact wasi-sysroot.tar.xz
 0:03.01 Using artifact from local cache: /home/ato/.mozbuild/toolchains/f87f0b51a1b1926d-wasi-sysroot.tar.xz
 0:03.10 rm tree: /home/ato/.mozbuild/wasi-sysroot
 0:03.11 untarring "/home/ato/.mozbuild/wasi-sysroot.tar.xz"

Your system should be ready to build Firefox for Desktop!

% ./mach clang-format 
 0:00.58 You're using an old version of clang-format binary. Please update to a more recent one by running: './mach bootstrap'

Comment 1

[Andreas Tolfsen ❲:ato❳]

Blowing away $HOME/.mozbuild/clang/bin/clang-format does not appear to help.

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1606452 - Update the version of clang-format in the configuration r?andi

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Also broke the clang-format CI :
https://treeherder.mozilla.org/logviewer.html#?job_id=283060548&repo=try /

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b757e97dfc26
Update the version of clang-format in the configuration r=andi

Comment 5

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/b757e97dfc26

Comment 6

[Andreas Tolfsen ❲:ato❳]

Thanks! Confirmed it’s working now.