1606511 - LeakSanitizer: [@ WorkerInput]

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: stack.txt

funfuzz found a non-reproducible leak on LSan with the following backtrace:

Backtrace:

Direct leak of 72 byte(s) in 3 object(s) allocated from:
    #0 0x558bc2c359f3 in __interceptor_malloc (/home/ubuntu/shell-cache/js-64-profDisabled-asan-linux-x86_64-781f53bf9c78/js-64-profDisabled-asan-linux-x86_64-781f53bf9c78+0x185f9f3)
    #1 0x558bc2caf9dc in js_arena_malloc(unsigned long, unsigned long) /home/ubuntu/shell-cache/js-64-profDisabled-asan-linux-x86_64-781f53bf9c78/objdir-js/dist/include/js/Utility.h:386:10
    #2 0x558bc2caf9dc in js_malloc(unsigned long) /home/ubuntu/shell-cache/js-64-profDisabled-asan-linux-x86_64-781f53bf9c78/objdir-js/dist/include/js/Utility.h:390
    #3 0x558bc2caf9dc in WorkerInput* js_new<WorkerInput, JSRuntime*, mozilla::UniquePtr<char16_t [], JS::FreePolicy>, unsigned long>(JSRuntime*&&, mozilla::UniquePtr<char16_t [], JS::FreePolicy>&&, unsigned long&&) /home/ubuntu/shell-cache/js-64-profDisabled-asan-linux-x86_64-781f53bf9c78/objdir-js/dist/include/js/Utility.h:539
    #4 0x558bc2caf9dc in EvalInWorker(JSContext*, unsigned int, JS::Value*) /home/ubuntu/trees/mozilla-central/js/src/shell/js.cpp:4058
/snip

For detailed crash information, see attachment.

Jan mentioned over email that it may be "a leak of the shell-only WorkerInput class, when we fail to create a new shell worker thread." Setting needinfo? from Jan as a start.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1606511 - Use UniquePtr more in JS shell worker thread code to avoid leaks. r?jwalden!

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:jandem, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 3

[Caroline Cullen [:caroline]]

Hey Jan, I was looking at this bug and was wondering if you were planning on landing the patch you have for it?

Comment 4

[Pablo]

Hi Jan
we are checking on really old bugs to see if we can close some or not.
Im wondering if this bug can be closed or it should stay open

Do you know?

thanks

Comment 5

[Jan de Mooij [:jandem]]

I posted a rebased version.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4572ad752598
Use UniquePtr more in JS shell worker thread code to avoid leaks. r=iain

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/4572ad752598