Closed Bug 1606608 Opened 4 years ago Closed 4 years ago

mTotalPixelCount gets out of sync when surfaces are deleted

Categories

(Core :: Graphics: WebRender, defect)

All
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla74
Tracking Status
firefox-esr68 --- unaffected
firefox72 --- unaffected
firefox73 --- wontfix
firefox74 --- fixed

People

(Reporter: mstange, Assigned: mstange)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

There was a small bug in the patch for bug 1604383 which causes the "WR OS Compositor frame" profiler markers to report unrealistic values.

This fixes RenderCompositorOGL::DestroySurface to update mTotalPixelCount as needed when there are still tiles in the surface that's getting removed.

I'm also adding a few asserts and performing some minor cleanup.

Assignee: nobody → mstange
Status: NEW → ASSIGNED
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/602c2c720a7f
Fix mTotalPixelCount bug and do some cleanup. r=gw
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74

Not sure if this needs uplift to Beta or not, but feel free to nominate it if so.

Flags: needinfo?(mstange)

Doesn't need to be uplifted, this affects a code path that's still off by default, and not in a user-facing way.

Flags: needinfo?(mstange)
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: