Closed Bug 1606613 Opened 5 months ago Closed 5 months ago

Stop logging handled errors

Categories

(Remote Protocol :: Agent, defect, P1)

defect

Tracking

(firefox73 fixed)

RESOLVED FIXED
Firefox 73
Tracking Status
firefox73 --- fixed

People

(Reporter: ato, Assigned: ato)

References

(Blocks 1 open bug)

Details

(Whiteboard: [puppeteer-beta-mvp])

Attachments

(1 file)

The remote agent currently logs handled errors to log.error() and there’s no need for that when the errors are being sent back to the client.

This is a left-over from when the remote agent was in a prototype stage and we couldn’t always rely on the Puppeteer client to interact with Firefox correctly.

There might be an argument to be made that we should be differentiating between RemoteAgentError derived errors and other errors, but the situation currently is that we use rely on several base errors (as well as NS result exceptions) to control the code flow.

Assignee: nobody → ato
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: [puppeteer-beta-reserve]
Blocks: 1591161

Errors that arise from use of the protocol, for example by the client
passing in the wrong argument or an operationg being unsupported, are
returned to the client. Since these are not inherent implementation
problems there is no point to double-logging them in the server.

This is a left-over from when the remote agent was in a prototype
stage and we couldn't always rely on the Puppeteer client to
interact with Firefox correctly.

Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ca9d646f56ba
remote: stop logging handled errors r=remote-protocol-reviewers,whimboo
Whiteboard: [puppeteer-beta-reserve] → [puppeteer-beta-mvp]
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 73
You need to log in before you can comment on or make changes to this bug.