1606636 - [wpt-sync] Sync PR 20998 - [css-pseudo] Let non-replaced images be list items with markers

Status: RESOLVED FIXED

(Core :: Layout: Generated Content, Lists, and Counters, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 20998 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20998
Details from upstream follow.

Oriol Brufau <[e-mail]> wrote:

[css-pseudo] Let non-replaced images be list items with markers

\<img> elements are usually replaced, so they can't originate a ::marker
pseudo-element even if they have 'display: list-item'.

However, if they point to an invalid image and have an alternative text,
then they are not replaced. Therefore they can have ::before and ::after
pseudo-elements, and also a ::marker if they have 'display: list-item'.

Before this patch, markers with 'content: normal' were never generated.
And non-normal ones worked fine in the inside case, but when outside
they triggerede a DCHECK failure because the marker was created but not
laid out.

BUG=1038644

TEST=external/wpt/css/css-pseudo/marker-content-017.html

The test fails in legacy because the 'content' property is not supported
yet in ::marker.

Change-Id: I4420bc2e9a0460f3a59fa030e5e3d249428aa6be
Reviewed-on: https://chromium-review.googlesource.com/1985759
WPT-Export-Revision: 13a969d67d5fe6a8c2cb99d23bed38448735e666

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=5c926ff7922ac6c46e7b4c5eb3f5a88bf0113efd

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=0c32cd35ca3ec13d0d03c0b198030679ce86246d

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a695c141202
[wpt PR 20998] - [css-pseudo] Let non-replaced images be list items with markers, a=testonly

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/5a695c141202