1606716 - search-textbox focusable area should include area outside the inner input

Status: VERIFIED FIXED

(Toolkit :: UI Widgets, defect, P3)

Description

[tustamido]

Attachment: 2020-01-02_17-13-02.gif

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:70.0) Gecko/20100101 Firefox/70.0

Steps to reproduce:

Since 1521280, when search-textbox was converted to a custom element, I often miss clicks to focus input texts. Even when the cursor changes to text, the element is not focused when I click (so that I can type something). This happens when the cursor is among the first 3px when it changes to text cursor.

I experience this a lot in Library "Search History'.

I will attach a gif screen recording. When I click, the textbox border flashes blue, but it's not focused (at least not the text input).

I'm on Windows 10, don't know if can be OS specific.

Comment 1

[Patrick (he/him)]

Able to reproduce on Beta 72, and Nightly 73.0a1 (2020-01-03)

Comment 2

[Patrick (he/him)]

This bug appears to be a regression - last good build 2019-05-09, first broken build 2019-05-10.

From mozregression:

2020-01-04T16:23:04: INFO : Narrowed inbound regression window from [b86c8998, c5798de8] (3 builds) to [73254a69, c5798de8] (2 builds) (~1 steps left)
2020-01-04T16:23:04: DEBUG : Starting merge handling...
2020-01-04T16:23:04: DEBUG : Using url: https://hg.mozilla.org/integration/autoland/json-pushes?changeset=c5798de806e28251aeda7d23123ab2b05eb7e8fb&full=1
2020-01-04T16:23:05: DEBUG : Found commit message:
Bug 1521280 - Convert search-textbox to a custom element. r=dao,bgrins

Differential Revision: https://phabricator.services.mozilla.com/D23045

Comment 3

[Tim Nguyen :ntim]

search-textbox.js needs to have this ported: https://hg.mozilla.org/mozilla-central/file/f977fdcfa5cf515065533627722f2ad54da4120c/toolkit/content/widgets/textbox.xml#l184

If someone wants to submit a patch, please feel free, I'm fairly busy over the coming weeks.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Hi Dao, is there someone who might be able to take comment 3 on?

Comment 5

[Dão Gottwald [:dao]]

Attachment: Bug 1606716 - Focus search-textbox when clicking outside the inner input. r=bgrins

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/83fec83639e4
Focus search-textbox when clicking outside the inner input. r=bgrins

Comment 7

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/83fec83639e4

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you're comfortable doing so.

Comment 9

[Dão Gottwald [:dao]]

I think we should just let this ride the 74 train at this point.

Comment 10

[Peter Magyari (Desktop QA)]

I have reproduced the issue on Windows 10 using Firefox Nightly 68.0a1(20190511220902)
I've also verified it on Nightly 74.0a1(20200131013147) and it has been fixed so I'm marking it accordingly.