[wpt-sync] Sync PR 21011 - [css-pseudo] Move all ::marker style adjustments into StyleAdjuster
Categories
(Core :: Layout: Generated Content, Lists, and Counters, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox74 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 21011 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/21011
Details from upstream follow.
Oriol Brufau <obrufau@igalia.com> wrote:
[css-pseudo] Move all ::marker style adjustments into StyleAdjuster
LayoutNGListItem was applying some style adjustments to markers, like
'white-space: pre' to preserve trailing spaces in outside markers.
But this was only affecting markers with 'content: normal', and the
changes weren't exposed in getComputedStyle().
This patch moves these adjustments into StyleAdjuster, so that all
markers are affected equally.BUG=457718
TEST=external/wpt/css/css-pseudo/marker-content-018.html
The test fails in legacy because the 'content' property is not supported
yet in ::marker.
There is a new failure in marker-supported-properties.html because now
'white-space' will compute to 'pre' in outside markers, even if you
specify a different value. But normal markers were already enforcing
'pre' at used value time anyways.Change-Id: I6d8b8ec7fb26cb04402032924f87b2c3b8fdb9cd
Reviewed-on: https://chromium-review.googlesource.com/1985966
WPT-Export-Revision: 9be46f15f1f04ff8c96b1844463bd07ed2fcd291
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 1•4 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=973f7b0e2f95b91fae586d1bdd7af3424099eb9d
|
|
Assignee | |
Comment 2•4 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=c2daa7a7cb96b6749f832e4c2ae5ceefdd6b56d2
|
|
Assignee | |
Comment 3•4 years ago
|
||
CI Results
Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 1 tests
Status Summary
Firefox
FAIL: 1
Chrome
FAIL: 1
Safari
PASS: 1
Links
Details
New Tests That Don't Pass
/css/css-pseudo/marker-content-018.html: FAIL (Chrome: FAIL, Safari: PASS)
|
|
Assignee | |
Comment 4•4 years ago
|
||
CI Results
Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 1 tests
Status Summary
Firefox
FAIL: 1
Chrome
FAIL: 1
Safari
PASS: 1
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
/css/css-pseudo/marker-content-018.html: FAIL (Chrome: FAIL, Safari: PASS)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fc5bd44f7f11 [wpt PR 21011] - [css-pseudo] Move all ::marker style adjustments into StyleAdjuster, a=testonly https://hg.mozilla.org/integration/autoland/rev/8209dc210831 [wpt PR 21011] - Update wpt metadata, a=testonly
|
||
Comment 6•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/fc5bd44f7f11
https://hg.mozilla.org/mozilla-central/rev/8209dc210831
Description
•