Closed
Bug 1606736
Opened 6 years ago
Closed 6 years ago
Remove redundant IsValid() check in SystemIsBeingShutDown()
Categories
(Core :: XPConnect, task, P3)
Core
XPConnect
Tracking
()
RESOLVED
FIXED
mozilla73
Tracking | Status | |
---|---|---|
firefox73 | --- | fixed |
People
(Reporter: mccr8, Assigned: mccr8)
Details
Attachments
(1 file)
XPCWrappedNativeScope::SystemIsBeingShutDown() does this:
if (wrapper->IsValid()) {
wrapper->SystemIsBeingShutDown();
}
...but XPCWrappedNative::SystemIsBeingShutDown() just returns immediately if the wrapper isn't valid, so this check is not needed. (I'm clearing out my old git branches in preparation for a new laptop...)
Assignee | ||
Comment 1•6 years ago
|
||
PCWrappedNative::SystemIsBeingShutDown() returns immediately if the
XPCWN isn't valid, so this check is not needed.
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e33851f3f935
Remove redundant IsValid() check in SystemIsBeingShutDown(). r=bzbarsky
Comment 3•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox73:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in
before you can comment on or make changes to this bug.
Description
•