Closed Bug 1606830 Opened 5 years ago Closed 5 years ago

compressedTexSubImage2D incorrect parameters validation

Categories

(Core :: Graphics: CanvasWebGL, defect, P2)

Product:
Core
Component:
Graphics: CanvasWebGL
Version:
71 Branch
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox73 --- wontfix
firefox74 --- unaffected

People

(Reporter: lexa.knyazev, Assigned: jgilbert)

References

Details

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3945.88 Safari/537.36

Steps to reproduce:

In WebGL 2 context, when a texture is uploaded from a PBO, compressedTexSubImage2D entrypoint accepts imageSize and offset parameters.

This check:
https://hg.mozilla.org/mozilla-central/file/tip/dom/canvas/WebGLTextureUpload.cpp#l206
incorrectly expects that the PBO's length is always equal to offset+imageSize.

Actual results:

INVALID_OPERATION: ImageSize doesn't match the required upload byte size.

Expected results:

No error.

Hey lexa.knyazev,

Will move this over to WebGL 2 component so devs can check it out with more in-depth knowledge of how it should work.

Component: Untriaged → Canvas: WebGL
Product: Firefox → Core
Priority: -- → P3
Status: UNCONFIRMED → NEW
Ever confirmed: true
Severity: normal → minor
Priority: P3 → P2
Severity: minor → normal
Assignee: nobody → jgilbert

Bug 1477756 may have fixed this.

73 is affected, 74 is not.

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox73: --- → wontfix
status-firefox74: --- → unaffected
Resolution: --- → FIXED
See Also: → webgl-ipc-refactor
You need to log in before you can comment on or make changes to this bug.