Closed Bug 1606861 Opened 7 months ago Closed 7 months ago

Some test tasks prefix has been changed from test-linux64-* to test-linux1804-64-*

Categories

(Firefox Build System :: Task Configuration, task)

task
Not set
normal

Tracking

(firefox74 fixed)

RESOLVED FIXED
mozilla74
Tracking Status
firefox74 --- fixed

People

(Reporter: marco, Assigned: egao)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

E.g. test-linux64-ccov/opt-cppunit-1proc became test-linux1804-64-ccov/opt-cppunit-1proc. Most other test tasks kept the old prefix.

There are some services relying on the prefix name, could it be reverted back?

Summary: Some test tasks prefix has been changed from → Some test tasks prefix has been changed from test-linux64-* to test-linux1804-64-*

this change was made so we could incrementally change tests from ubuntu 16.04 to ubuntu 18.04 in a migration.

should we leave the ccov tests alone until everything else is done? Other factors to consider?

should we leave the ccov tests alone until everything else is done?

If possible, that'd be great. Or at least postponing it until we make the code-coverage related tools independent of the whole prefix.

What will the end result be after everything is done? All will be test-linux64-* or test-linux1804-64-*?

Other factors to consider?

There might be other things relying on the prefix, I don't know. E.g. some ActiveData queries using "prefix" filter.

everything will be linux64-1804-64/ccov in the future. Keep in mind in a couple weeks we might be ready to switch.

:egao, can you revert back the ccov changes to be on 16.04 for now?

Flags: needinfo?(egao)

(In reply to Joel Maher ( :jmaher ) (UTC-4) from comment #3)

everything will be linux64-1804-64/ccov in the future. Keep in mind in a couple weeks we might be ready to switch.

:egao, can you revert back the ccov changes to be on 16.04 for now?

OK, thanks! With https://github.com/mozilla/code-coverage/pull/352 we should be more flexible to such changes.

Note it won't land so soon because have another release in-flight, so it'd still be good to revert the ccov naming changes for the time being.
We will land it before the switch.

(In reply to Marco Castelluccio [:marco] (PTO until January 2) from comment #0)

E.g. test-linux64-ccov/opt-cppunit-1proc became test-linux1804-64-ccov/opt-cppunit-1proc. Most other test tasks kept the old prefix.

There are some services relying on the prefix name, could it be reverted back?

Yes, I did change the prefix as part of the step by step migration from existing ubuntu1604 to ubuntu1804.

I will put a patch to exclude the linux64-ccov builds from this change.

As for the final prefix, I have had feedback from :aionescu that it should be shorter, say test-linux18-<etc>, but I'm leaning to sticking with including the minor release version in the name.

Flags: needinfo?(egao)
Assignee: nobody → egao
Status: NEW → ASSIGNED
Pushed by egao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/436a9ce642ae
revert changes to linux64-ccov labels and exclude the platform from further ubuntu1804 migration changes r=marco,jmaher
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74

It seems like all those jobs are being run twice now.

Flags: needinfo?(egao)

(In reply to Marco Castelluccio [:marco] from comment #9)

It seems like all those jobs are being run twice now.

Not sure what you mean. Are you referring to how some tests are duplicated?

If so, that is expected, since the test platform combination for linux1804-64-ccov was not disabled, and that continues to run the set of tests I've verified to be green for the ccov platform.

Flags: needinfo?(egao) → needinfo?(mcastelluccio)

Oh, ok, I thought your patch would just make them run only on the previous platform. Nevermind then. I'll ping you when we release the new code-coverage version which doesn't require the old prefix anymore.

Flags: needinfo?(mcastelluccio)
See Also: → 1608251
You need to log in before you can comment on or make changes to this bug.