1606930 - Unify address bar focus border across platforms

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement, P2)

Description

[Harry Twyford]

On macOS, the border around the expanded Urlbar and UrlbarView is our standard macOS focus ring. This doesn't make sense on an input as large as the expanded Urlbar and especially not the UrlbarView. Verdi is working on a design for a cross-platform border. We may just end up using the Windows/Linux border on macOS.

Comment 1

[Harry Twyford]

Verdi suggests that we use the Windows/Linux border on macOS.

Comment 2

[Dão Gottwald [:dao]]

Should be as simple as removing this unless I'm missing something: https://searchfox.org/mozilla-central/rev/ba4fab1cc2f1c9c4e07cdb71542b8d441707c577/browser/themes/osx/browser.css#259,265-269

Comment 3

[Harry Twyford]

Attachment: Bug 1606930 - Unify address bar focus border across platforms. r?dao

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4f949a4e91ff
Unify address bar focus border across platforms. r=dao

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/4f949a4e91ff

Comment 6

[Mehmet]

Attachment: Bildschirmfoto 2020-01-13 um 17.03.14.png

Hmmm... The blue color should be at least the macOS System Default Blue. The 1px highlight is fine but In my opinion the highlight a bit too dark, especially in Dark Mode.

Comment 7

[Mehmet]

Attachment: Chrome vs Safari vs Firefox

Attached a comparison -> Chrome vs Safari vs Firefox

Comment 8

[Drew Willcoxon :adw]

Could you file a new bug and mark it blocking this one, please?

Comment 9

[Mehmet]

(In reply to Drew Willcoxon :adw from comment #8)

Could you file a new bug and mark it blocking this one, please?

Sorry. I didn't realized your comment :( Otherwise I would of course have opened a report.

@Harry Twyford: Thanks for opening it :)